[U-Boot] [PATCH] tools: image: fix node name of signature node in FIT
Both "conf_name" and "sig_name" point to the name of config node. The latter should be the name of the signature node.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/image-host.c b/tools/image-host.c index e82020b..eaa9c41 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -515,7 +515,7 @@ static int fit_config_get_data(void *fit, int conf_noffset, int noffset, int ret, len;
conf_name = fit_get_name(fit, conf_noffset, NULL); - sig_name = fit_get_name(fit, conf_noffset, NULL); + sig_name = fit_get_name(fit, noffset, NULL); debug("%s: conf='%s', sig='%s'\n", __func__, conf_name, sig_name);
/* Get a list of nodes we want to hash */
On 19 October 2017 at 12:16, Masahiro Yamada yamada.masahiro@socionext.com wrote:
Both "conf_name" and "sig_name" point to the name of config node. The latter should be the name of the signature node.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
There is no test which checks this?
Hi Simon,
2017-10-22 23:36 GMT+09:00 Simon Glass sjg@chromium.org:
On 19 October 2017 at 12:16, Masahiro Yamada yamada.masahiro@socionext.com wrote:
Both "conf_name" and "sig_name" point to the name of config node. The latter should be the name of the signature node.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
There is no test which checks this?
The "sig_name" is only used as an argument to printf() in this function. So, test/py cannot detect this.
On Thu, Oct 19, 2017 at 07:16:21PM +0900, Masahiro Yamada wrote:
Both "conf_name" and "sig_name" point to the name of config node. The latter should be the name of the signature node.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Masahiro Yamada -
Simon Glass -
Tom Rini