[U-Boot] [PATCH] mkimage: Fix argument parsing with signature comment

From: Karl Beldan karl.beldan@baylibre.com
Signed-off-by: Karl Beldan karl.beldan@baylibre.com --- tools/mkimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mkimage.c b/tools/mkimage.c index d993958..3c594a0 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -140,7 +140,7 @@ static void process_args(int argc, char **argv) int opt;
while ((opt = getopt(argc, argv, - "a:A:b:cC:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) { + "a:A:b:c:C:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) { switch (opt) { case 'a': params.addr = strtoull(optarg, &ptr, 16);

On Tue, Aug 02, 2016 at 08:49:55AM +0000, Karl Beldan wrote:
From: Karl Beldan karl.beldan@baylibre.com
Signed-off-by: Karl Beldan karl.beldan@baylibre.com
tools/mkimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mkimage.c b/tools/mkimage.c index d993958..3c594a0 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -140,7 +140,7 @@ static void process_args(int argc, char **argv) int opt;
while ((opt = getopt(argc, argv,
"a:A:b:cC:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) {
"a:A:b:c:C:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) {
Can you please add in a message and perhaps a Fixes: ... ? Thanks!

Inform getopt that '-c' requires a parameter.
Fixes: a02221f29deb ("mkimage: Convert to use getopt()") Signed-off-by: Karl Beldan kbeldan@baylibre.com --- tools/mkimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mkimage.c b/tools/mkimage.c index d993958..3c594a0 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -140,7 +140,7 @@ static void process_args(int argc, char **argv) int opt;
while ((opt = getopt(argc, argv, - "a:A:b:cC:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) { + "a:A:b:c:C:d:D:e:Ef:Fk:K:ln:p:O:rR:qsT:vVx")) != -1) { switch (opt) { case 'a': params.addr = strtoull(optarg, &ptr, 16);

On Tue, Aug 02, 2016 at 06:57:14PM +0000, Karl Beldan wrote:
Inform getopt that '-c' requires a parameter.
Fixes: a02221f29deb ("mkimage: Convert to use getopt()") Signed-off-by: Karl Beldan kbeldan@baylibre.com
Reviewed-by: Tom Rini trini@konsulko.com

On Tue, Aug 02, 2016 at 06:57:14PM +0000, Karl Beldan wrote:
Inform getopt that '-c' requires a parameter.
Fixes: a02221f29deb ("mkimage: Convert to use getopt()") Signed-off-by: Karl Beldan kbeldan@baylibre.com Reviewed-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!
participants (2)
-
Karl Beldan
-
Tom Rini