[U-Boot] [PATCH 09/31] powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
The size of the serial RXBuffer is increased from 16 to 128 bytes to enable comfortable copy-and-paste of commands with the mouse
Signed-off-by: Thomas Herzmann thomas.herzmann@keymile.com Signed-off-by: Heiko Schocher hs@denx.de --- include/configs/mgcoge.h | 2 +- include/configs/mgsuvd.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h index f772627..07e0b8e 100644 --- a/include/configs/mgcoge.h +++ b/include/configs/mgcoge.h @@ -50,7 +50,7 @@ #undef CONFIG_CONS_ON_SCC /* It's not on SCC */ #undef CONFIG_CONS_NONE /* It's not on external UART */ #define CONFIG_CONS_INDEX 2 /* SMC2 is used for console */ -#define CONFIG_SYS_SMC_RXBUFLEN 16 +#define CONFIG_SYS_SMC_RXBUFLEN 128
/* * Select ethernet configuration diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h index ee1da02..05e770e 100644 --- a/include/configs/mgsuvd.h +++ b/include/configs/mgsuvd.h @@ -45,7 +45,7 @@ #define CONFIG_SYS_SMC_UCODE_PATCH 1 /* Relocate SMC1 */ #define CONFIG_SYS_SMC_DPMEM_OFFSET 0x1fc0 #define CONFIG_8xx_CONS_SMC1 1 /* Console is on SMC1 */ -#define CONFIG_SYS_SMC_RXBUFLEN 16 +#define CONFIG_SYS_SMC_RXBUFLEN 128
#define CONFIG_SYS_CPM_BOOTCOUNT_ADDR 0x1eb0 /* In case of SMC relocation, the * default value is not working */

Dear Heiko Schocher,
In message 498027CB.8030903@denx.de you wrote:
powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
The size of the serial RXBuffer is increased from 16 to 128 bytes to enable comfortable copy-and-paste of commands with the mouse
Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?
Best regards,
Wolfgang Denk

Hello Wolfgang,
Wolfgang Denk wrote:
In message 498027CB.8030903@denx.de you wrote:
powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
The size of the serial RXBuffer is increased from 16 to 128 bytes to enable comfortable copy-and-paste of commands with the mouse
Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?
Because it shows a development history.
bye Heiko

Dear Heiko Schocher,
In message 49805339.8090802@denx.de you wrote:
Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?
Because it shows a development history.
I think it would be better to fold the second patch into the first one.
Best regards,
Wolfgang Denk
participants (2)
-
Heiko Schocher
-
Wolfgang Denk