[U-Boot] worth correcting spelling of "redundand"?
again, my pedantry getting the best of me but it makes me cringe whenever i run across the spelling "redundand" (tree-wide search):
common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT common/env_ubi.c:#else /* ! CONFIG_SYS_REDUNDAND_ENVIRONMENT */ common/env_ubi.c:#endif /* CONFIG_SYS_REDUNDAND_ENVIRONMENT */ common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT common/env_ubi.c:#else /* ! CONFIG_SYS_REDUNDAND_ENVIRONMENT */ common/env_ubi.c:#endif /* CONFIG_SYS_REDUNDAND_ENVIRONMENT */ common/env_embedded.c:env_t redundand_environment __PPCENV__ = { include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/environment.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT include/environment.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT include/env_default.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT include/configs/G2000.h:#else /* DEFAULT: environment in flash, using redundand flash sectors */ include/configs/km/km_arm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/configs/PPChameleonEVB.h:#else /* DEFAULT: environment in flash, using redundand flash sectors */ include/configs/mx28evk.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/configs/am335x_evm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/configs/omap5_uevm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT include/configs/igep0033.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT tools/envcrc.c:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT tools/envcrc.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
this obviously isn't a cosmetic change as it's used in numerous #defines, but if it's done all at once, it should be safe. i can submit a patch unless people feel it's simply too disruptive.
rday
Hi Robert,
On Mon, 16 Sep 2013 04:30:09 -0400 (EDT), "Robert P. J. Day" rpjday@crashcourse.ca wrote:
again, my pedantry getting the best of me but it makes me cringe whenever i run across the spelling "redundand" (tree-wide search):
common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT [...]
this obviously isn't a cosmetic change as it's used in numerous #defines, but if it's done all at once, it should be safe. i can submit a patch unless people feel it's simply too disruptive.
As a general rule, you don't need to ask before submitting a patch unless you're really doing intrusive and potentially disruptive work and want some feedback without risking getting bad code mainlined, in which case... you'd still submit a patch, only tagged RFC. :)
IOW: just submit the patch; after all, the worst possible outcome is only a NAK if you missed something important.
Here, just submit a patch with a summary line / subject like "fix CONFIG_SYS_REDUNDAND_ENVIRONMENT typo".
rday
Amicalement,
participants (2)
-
Albert ARIBAUD -
Robert P. J. Day