[U-Boot] [PATCH] sh: Fix building ecovec board
Build error was with board/renesas/ecovec/lowlevel_init.S include/version.h: Assembler messages: include/version.h:41: Error: unknown opcode lowlevel_init.S:48: Error: unknown opcode lowlevel_init.S:51: Error: unknown opcode etc
Signed-off-by: Phil Edworthy phil.edworthy@renesas.com --- board/renesas/ecovec/Makefile | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/board/renesas/ecovec/Makefile b/board/renesas/ecovec/Makefile index 8fdc0c9..b592a9c 100644 --- a/board/renesas/ecovec/Makefile +++ b/board/renesas/ecovec/Makefile @@ -25,8 +25,12 @@ LIB = $(obj)lib$(BOARD).o COBJS := ecovec.o SOBJS := lowlevel_init.o
-$(LIB): $(obj).depend $(COBJS) $(SOBJS) - $(call cmd_link_o_target, $(COBJS) $(SOBJS)) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
#########################################################################
Hi,
I cannot reproduce this problem. I am using gcc-4.6 and gcc-4.4. And I think that this problem is not revised with your patch.
I think that the contents of the patch are right.
Best regards, Nobuhiro
2012/3/17 Phil Edworthy phil.edworthy@renesas.com:
Build error was with board/renesas/ecovec/lowlevel_init.S include/version.h: Assembler messages: include/version.h:41: Error: unknown opcode lowlevel_init.S:48: Error: unknown opcode lowlevel_init.S:51: Error: unknown opcode etc
Signed-off-by: Phil Edworthy phil.edworthy@renesas.com
board/renesas/ecovec/Makefile | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/board/renesas/ecovec/Makefile b/board/renesas/ecovec/Makefile index 8fdc0c9..b592a9c 100644 --- a/board/renesas/ecovec/Makefile +++ b/board/renesas/ecovec/Makefile @@ -25,8 +25,12 @@ LIB = $(obj)lib$(BOARD).o COBJS := ecovec.o SOBJS := lowlevel_init.o
-$(LIB): $(obj).depend $(COBJS) $(SOBJS)
- $(call cmd_link_o_target, $(COBJS) $(SOBJS))
+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS))
+$(LIB): $(OBJS) $(SOBJS)
- $(call cmd_link_o_target, $(OBJS) $(SOBJS))
#########################################################################
-- 1.7.0.4
Hi Nobuhiro,
I cannot reproduce this problem. I am using gcc-4.6 and gcc-4.4.
I used the CodeSourcery G++ Lite 4.4-200 toolchain.
And I think that this problem is not revised with your patch. I think that the contents of the patch are right.
My change makes the ecovec Makefile the same structure as the other SH boards.
I checked and found that the build error only occurs with out-of-tree builds.
2012/3/17 Phil Edworthy phil.edworthy@renesas.com:
Build error was with board/renesas/ecovec/lowlevel_init.S include/version.h: Assembler messages: include/version.h:41: Error: unknown opcode lowlevel_init.S:48: Error: unknown opcode lowlevel_init.S:51: Error: unknown opcode etc
Signed-off-by: Phil Edworthy phil.edworthy@renesas.com
board/renesas/ecovec/Makefile | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/board/renesas/ecovec/Makefile b/board/renesas/ecovec/Makefile index 8fdc0c9..b592a9c 100644 --- a/board/renesas/ecovec/Makefile +++ b/board/renesas/ecovec/Makefile @@ -25,8 +25,12 @@ LIB = $(obj)lib$(BOARD).o COBJS := ecovec.o SOBJS := lowlevel_init.o
-$(LIB): $(obj).depend $(COBJS) $(SOBJS)
- $(call cmd_link_o_target, $(COBJS) $(SOBJS))
+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS))
+$(LIB): $(OBJS) $(SOBJS)
- $(call cmd_link_o_target, $(OBJS) $(SOBJS))
#########################################################################
-- 1.7.0.4
Best regards, Phil
Hi,
2012/3/21 phil.edworthy@renesas.com:
Hi Nobuhiro,
I cannot reproduce this problem. I am using gcc-4.6 and gcc-4.4.
I used the CodeSourcery G++ Lite 4.4-200 toolchain.
And I think that this problem is not revised with your patch. I think that the contents of the patch are right.
My change makes the ecovec Makefile the same structure as the other SH boards.
I checked and found that the build error only occurs with out-of-tree builds.
OK, I confirmed this with out-of-tree build. Applied.
Thanks. Nobuhiro
2012/3/17 Phil Edworthy phil.edworthy@renesas.com:
Build error was with board/renesas/ecovec/lowlevel_init.S include/version.h: Assembler messages: include/version.h:41: Error: unknown opcode lowlevel_init.S:48: Error: unknown opcode lowlevel_init.S:51: Error: unknown opcode etc
Signed-off-by: Phil Edworthy phil.edworthy@renesas.com
board/renesas/ecovec/Makefile | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/board/renesas/ecovec/Makefile b/board/renesas/ecovec/Makefile index 8fdc0c9..b592a9c 100644 --- a/board/renesas/ecovec/Makefile +++ b/board/renesas/ecovec/Makefile @@ -25,8 +25,12 @@ LIB = $(obj)lib$(BOARD).o COBJS := ecovec.o SOBJS := lowlevel_init.o
-$(LIB): $(obj).depend $(COBJS) $(SOBJS)
- $(call cmd_link_o_target, $(COBJS) $(SOBJS))
+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS))
+$(LIB): $(OBJS) $(SOBJS)
- $(call cmd_link_o_target, $(OBJS) $(SOBJS))
#########################################################################
-- 1.7.0.4
Best regards, Phil
participants (3)
-
Nobuhiro Iwamatsu -
Phil Edworthy -
phil.edworthy＠renesas.com