[U-Boot] [PATCH 1/1] env: correct sign for error code

8 May
2017
8 May
'17
7:30 p.m.
Error codes should be negative.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- common/env_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/env_attr.c b/common/env_attr.c index 5bfe5e3a89..386219087b 100644 --- a/common/env_attr.c +++ b/common/env_attr.c @@ -153,7 +153,7 @@ static int regex_callback(const char *name, const char *attributes, void *priv) } } else { printf("Error compiling regex: %s\n", slre.err_str); - retval = EINVAL; + retval = -EINVAL; } done: return retval;
--
2.11.0

12 May
12 May
7:21 p.m.
New subject: [U-Boot] [U-Boot,1/1] env: correct sign for error code
On Mon, May 08, 2017 at 07:30:58PM +0200, xypron.glpk@gmx.de wrote:
Error codes should be negative.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
--
Tom
2920
Age (days ago)
2924
Last active (days ago)
1 comments
2 participants
participants (2)
-
Heinrich Schuchardt
-
Tom Rini