[PATCH 1/2] arm64: dts: rk3399-rock-pi-4b-u-boot: add optee node

Allow u-boot to probe optee so we can access secure os from the bootloader.
Signed-off-by: Peter Griffin peter.griffin@linaro.org --- arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi index 85ee5770ad..95ca99ecbc 100644 --- a/arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi @@ -4,3 +4,13 @@ */
#include "rk3399-rock-pi-4-u-boot.dtsi" + +/ { + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + +};

Signed-off-by: Peter Griffin peter.griffin@linaro.org --- configs/rock-pi-4-rk3399_defconfig | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig index 4f15627d59..93dfeb9d95 100644 --- a/configs/rock-pi-4-rk3399_defconfig +++ b/configs/rock-pi-4-rk3399_defconfig @@ -54,6 +54,8 @@ CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y +CONFIG_TEE=y +CONFIG_OPTEE=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y @@ -75,3 +77,4 @@ CONFIG_VIDEO_ROCKCHIP=y CONFIG_DISPLAY_ROCKCHIP_HDMI=y CONFIG_SPL_TINY_MEMSET=y CONFIG_ERRNO_STR=y +# CONFIG_OPTEE_LIB is not set

On Mon, 21 Feb 2022 at 09:13, Peter Griffin peter.griffin@linaro.org wrote:
Signed-off-by: Peter Griffin peter.griffin@linaro.org
configs/rock-pi-4-rk3399_defconfig | 3 +++ 1 file changed, 3 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org

Hi Peter, Thanks for your patch, could you add a description in the commit message about why do we need to enable OPTEE in U-Boot, I think this is the first commit for RK3399 to enable OPTEE.
Thanks, - Kever
Peter Griffin peter.griffin@linaro.org 于2022年2月22日周二 00:13写道:
Signed-off-by: Peter Griffin peter.griffin@linaro.org
configs/rock-pi-4-rk3399_defconfig | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig index 4f15627d59..93dfeb9d95 100644 --- a/configs/rock-pi-4-rk3399_defconfig +++ b/configs/rock-pi-4-rk3399_defconfig @@ -54,6 +54,8 @@ CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y +CONFIG_TEE=y +CONFIG_OPTEE=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y @@ -75,3 +77,4 @@ CONFIG_VIDEO_ROCKCHIP=y CONFIG_DISPLAY_ROCKCHIP_HDMI=y CONFIG_SPL_TINY_MEMSET=y CONFIG_ERRNO_STR=y
+# CONFIG_OPTEE_LIB is not set
2.25.1

Hi Peter,
On Mon, 21 Feb 2022 at 09:13, Peter Griffin peter.griffin@linaro.org wrote:
Allow u-boot to probe optee so we can access secure os from the bootloader.
Signed-off-by: Peter Griffin peter.griffin@linaro.org
arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
Binman has a tee-os entry type now so please use that. Also please see my series which converts rockchip 64-bit boards to binman.
Regards, Simon
participants (3)
-
Kever Yang
-
Peter Griffin
-
Simon Glass