[U-Boot] [PATCH] mmc: drop unnecessary send_status request
It's redundant to send cmd13 after cmd9 whose response is not R1b. The card devices will not be busy w/ cmd9.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com ---
drivers/mmc/mmc.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 3648950..72fc177 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1111,7 +1111,6 @@ static int mmc_startup(struct mmc *mmc) struct mmc_cmd cmd; ALLOC_CACHE_ALIGN_BUFFER(u8, ext_csd, MMC_MAX_BLOCK_LEN); ALLOC_CACHE_ALIGN_BUFFER(u8, test_csd, MMC_MAX_BLOCK_LEN); - int timeout = 1000; bool has_parts = false; bool part_completed; struct blk_desc *bdesc; @@ -1167,9 +1166,6 @@ static int mmc_startup(struct mmc *mmc)
err = mmc_send_cmd(mmc, &cmd, NULL);
- /* Waiting for the ready status */ - mmc_send_status(mmc, timeout); - if (err) return err;
Hi,
On 03/12/2017 03:19 PM, Ziyuan Xu wrote:
It's redundant to send cmd13 after cmd9 whose response is not R1b. The card devices will not be busy w/ cmd9.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Applied on u-boot-mmc. Thanks!
Best Regards, Jaehoon Chung
drivers/mmc/mmc.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 3648950..72fc177 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1111,7 +1111,6 @@ static int mmc_startup(struct mmc *mmc) struct mmc_cmd cmd; ALLOC_CACHE_ALIGN_BUFFER(u8, ext_csd, MMC_MAX_BLOCK_LEN); ALLOC_CACHE_ALIGN_BUFFER(u8, test_csd, MMC_MAX_BLOCK_LEN);
- int timeout = 1000; bool has_parts = false; bool part_completed; struct blk_desc *bdesc;
@@ -1167,9 +1166,6 @@ static int mmc_startup(struct mmc *mmc)
err = mmc_send_cmd(mmc, &cmd, NULL);
- /* Waiting for the ready status */
- mmc_send_status(mmc, timeout);
- if (err) return err;
participants (2)
-
Jaehoon Chung -
Ziyuan Xu