[U-Boot] [PATCH] x86: Pass correct cpu_index to ap_init()
In sipi_vector.S, cpu_index (passed as %eax) is wrongly overwritten by the ap_init() function address. Correct it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
arch/x86/cpu/sipi_vector.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/cpu/sipi_vector.S b/arch/x86/cpu/sipi_vector.S index bcef12c..0c4a157 100644 --- a/arch/x86/cpu/sipi_vector.S +++ b/arch/x86/cpu/sipi_vector.S @@ -190,8 +190,8 @@ load_msr:
/* c_handler(cpu_num) */ movl %esi, %eax /* cpu_num */ - mov c_handler, %eax - call *%eax + mov c_handler, %esi + call *%esi
.align 4 .globl sipi_params
Hi Bin,
On 14 October 2015 at 03:01, Bin Meng bmeng.cn@gmail.com wrote:
In sipi_vector.S, cpu_index (passed as %eax) is wrongly overwritten by the ap_init() function address. Correct it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/sipi_vector.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Simon Glass sjg@chromium.org
I wonder if this value is even useful, but we do use it for debug output.
Regards, Simon
On 15 October 2015 at 06:22, Simon Glass sjg@chromium.org wrote:
Hi Bin,
On 14 October 2015 at 03:01, Bin Meng bmeng.cn@gmail.com wrote:
In sipi_vector.S, cpu_index (passed as %eax) is wrongly overwritten by the ap_init() function address. Correct it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/sipi_vector.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Simon Glass sjg@chromium.org
I wonder if this value is even useful, but we do use it for debug output.
Applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng -
Simon Glass