[PATCH 1/1] pico-imx7d: fix typo in AR8035 comment
From: Benjamin Szőke egyszeregy@freemail.hu
Signed-off-by: Benjamin Szőke egyszeregy@freemail.hu --- board/technexion/pico-imx7d/pico-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c index 6e98b85b28..7f5a092457 100644 --- a/board/technexion/pico-imx7d/pico-imx7d.c +++ b/board/technexion/pico-imx7d/pico-imx7d.c @@ -106,7 +106,7 @@ int board_phy_config(struct phy_device *phydev) { unsigned short val;
- /* To enable AR8035 ouput a 125MHz clk from CLK_25M */ + /* To enable AR8035 output a 125MHz clk from CLK_25M */ phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7); phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016); phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
On Fri, Nov 3, 2023 at 6:16 PM egyszeregy@freemail.hu wrote:
From: Benjamin Szőke egyszeregy@freemail.hu
Signed-off-by: Benjamin Szőke egyszeregy@freemail.hu
Please make sure to run checkpatch and make it happy:
./scripts/checkpatch.pl 0001-pico-imx7d-fix-typo-in-AR8035-comment.patch WARNING: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
Also, it would be better to submit this patch as part of a series.
Hi Benjamin,
On Fri, Nov 3, 2023 at 6:16 PM egyszeregy@freemail.hu wrote:
From: Benjamin Szőke egyszeregy@freemail.hu
Signed-off-by: Benjamin Szőke egyszeregy@freemail.hu
board/technexion/pico-imx7d/pico-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c index 6e98b85b28..7f5a092457 100644 --- a/board/technexion/pico-imx7d/pico-imx7d.c +++ b/board/technexion/pico-imx7d/pico-imx7d.c @@ -106,7 +106,7 @@ int board_phy_config(struct phy_device *phydev) { unsigned short val;
/* To enable AR8035 ouput a 125MHz clk from CLK_25M */
/* To enable AR8035 output a 125MHz clk from CLK_25M */
After looking closer to this code, now that we have Ethernet DM in place, this whole board_phy_config() can be removed completely. This also causes the typo to be removed :-)
Here is the patch I sent: https://lore.kernel.org/u-boot/20231103224733.59410-1-festevam@gmail.com/
participants (2)
-
egyszeregy＠freemail.hu -
Fabio Estevam