[PATCH] doc: icicle: Fix incorrect board name in HSS docs
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match.
Signed-off-by: Sean Anderson seanga2@gmail.com ---
doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow
.. code-block:: none
- make BOARD=icicle-kit-es config + make BOARD=mpfs-icicle-kit-es config
Alternatively, copy the default config for Microchip boot-flow.
.. code-block:: none
- cp boards/icicle-kit-es/def_config .config + cp boards/mpfs-icicle-kit-es/def_config .config
-2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will create hss.elf and various binary formats (hss.hex and hss.bin).
On Thu, Mar 11, 2021 at 9:48 AM Sean Anderson seanga2@gmail.com wrote:
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match.
Signed-off-by: Sean Anderson seanga2@gmail.com
doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Hi Sean,
On Thu, Mar 11, 2021 at 7:18 AM Sean Anderson seanga2@gmail.com wrote:
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match.
Signed-off-by: Sean Anderson seanga2@gmail.com
doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow
.. code-block:: none
- make BOARD=icicle-kit-es config
- make BOARD=mpfs-icicle-kit-es config
Alternatively, copy the default config for Microchip boot-flow.
.. code-block:: none
- cp boards/icicle-kit-es/def_config .config
- cp boards/mpfs-icicle-kit-es/def_config .config
-2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will create hss.elf and various binary formats (hss.hex and hss.bin).
The "mpfs" prefix added only for Microchip boot flow of the HSS but not Custom boot flow of the HSS.
Regards Padmarao
-- 2.30.1
On 3/16/21 12:05 AM, Padmarao Begari wrote:
Hi Sean,
On Thu, Mar 11, 2021 at 7:18 AM Sean Anderson <seanga2@gmail.com mailto:seanga2@gmail.com> wrote:
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match. Signed-off-by: Sean Anderson <seanga2@gmail.com <mailto:seanga2@gmail.com>> --- doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow .. code-block:: none - make BOARD=icicle-kit-es config + make BOARD=mpfs-icicle-kit-es config Alternatively, copy the default config for Microchip boot-flow. .. code-block:: none - cp boards/icicle-kit-es/def_config .config + cp boards/mpfs-icicle-kit-es/def_config .config -2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will create hss.elf and various binary formats (hss.hex and hss.bin).The "mpfs" prefix added only for Microchip boot flow of the HSS but not Custom boot flow of the HSS.
Do you mean that
* The "mpfs" prefix should be used for both microchip boot flow and custom boot flow, this patch adds it only to the microchip boot flow, and this patch should be modified to add it to both. * The "mpfs" prefix should be used only for the microchip boot flow and not be used for the custom boot flow, this patch adds it to both the microchip boot flow and the custom boot flow, and this patch should be modified to only add it to the custom boot flow.
Or something else entirely?
Thanks,
--Sean
Regards Padmarao
-- 2.30.1
Hi Sean,
On Tue, Mar 16, 2021 at 9:52 AM Sean Anderson seanga2@gmail.com wrote:
On 3/16/21 12:05 AM, Padmarao Begari wrote:
Hi Sean,
On Thu, Mar 11, 2021 at 7:18 AM Sean Anderson <seanga2@gmail.com
mailto:seanga2@gmail.com> wrote:
The HSS source uses an "mpfs" prefix with the icicle board name.Change our
documentation to match. Signed-off-by: Sean Anderson <seanga2@gmail.com <mailto:seanga2@gmail.com>>
--- doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/board/microchip/mpfs_icicle.rstb/doc/board/microchip/mpfs_icicle.rst
index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) -Microchip boot-flow
.. code-block:: none - make BOARD=icicle-kit-es config + make BOARD=mpfs-icicle-kit-es config Alternatively, copy the default config for Microchip boot-flow. .. code-block:: none - cp boards/icicle-kit-es/def_config .config + cp boards/mpfs-icicle-kit-es/def_config .config -2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will createhss.elf and
various binary formats (hss.hex and hss.bin).The "mpfs" prefix added only for Microchip boot flow of the HSS but not
Custom boot flow of the HSS.
Do you mean that
- The "mpfs" prefix should be used for both microchip boot flow and custom boot flow, this patch adds it only to the microchip boot flow, and this patch should be modified to add it to both.
The "mpfs" prefix should be used for both microchip boot flow and custom boot flow, this patch adds it only to the microchip boot flow, and this patch should be modified to add it to both.
Regards Padmarao
- The "mpfs" prefix should be used only for the microchip boot flow and not be used for the custom boot flow, this patch adds it to both the microchip boot flow and the custom boot flow, and this patch should be modified to only add it to the custom boot flow.
Or something else entirely?
Thanks,
--Sean
Regards Padmarao
-- 2.30.1
On 3/16/21 12:15 AM, Padmarao Begari wrote:
Hi Sean,
On Tue, Mar 16, 2021 at 9:52 AM Sean Anderson <seanga2@gmail.com mailto:seanga2@gmail.com> wrote:
On 3/16/21 12:05 AM, Padmarao Begari wrote: > Hi Sean, > > On Thu, Mar 11, 2021 at 7:18 AM Sean Anderson <seanga2@gmail.com <mailto:seanga2@gmail.com> <mailto:seanga2@gmail.com <mailto:seanga2@gmail.com>>> wrote: > > The HSS source uses an "mpfs" prefix with the icicle board name. Change our > documentation to match. > > Signed-off-by: Sean Anderson <seanga2@gmail.com <mailto:seanga2@gmail.com> <mailto:seanga2@gmail.com <mailto:seanga2@gmail.com>>> > --- > > doc/board/microchip/mpfs_icicle.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst > index c71c2f3cab..cd18472542 100644 > --- a/doc/board/microchip/mpfs_icicle.rst > +++ b/doc/board/microchip/mpfs_icicle.rst > @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow > > .. code-block:: none > > - make BOARD=icicle-kit-es config > + make BOARD=mpfs-icicle-kit-es config > > Alternatively, copy the default config for Microchip boot-flow. > > .. code-block:: none > > - cp boards/icicle-kit-es/def_config .config > + cp boards/mpfs-icicle-kit-es/def_config .config > > -2. make BOARD=icicle-kit-es > +2. make BOARD=mpfs-icicle-kit-es > 3. In the Default subdirectory, the standard build will create hss.elf and > various binary formats (hss.hex and hss.bin). > > > The "mpfs" prefix added only for Microchip boot flow of the HSS but not Custom boot flow of the HSS. Do you mean that * The "mpfs" prefix should be used for both microchip boot flow and custom boot flow, this patch adds it only to the microchip boot flow, and this patch should be modified to add it to both.The "mpfs" prefix should be used for both microchip boot flow and custom boot flow, this patch adds it only to the microchip boot flow, and this patch should be modified to add it to both.
Ok, thanks. I have only tried building the microchip boot flow so far.
--Sean
On 11.03.21 02:48, Sean Anderson wrote:
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match.
Signed-off-by: Sean Anderson seanga2@gmail.com
doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow
.. code-block:: none
- make BOARD=icicle-kit-es config
- make BOARD=mpfs-icicle-kit-es config
Alternatively, copy the default config for Microchip boot-flow.
.. code-block:: none
- cp boards/icicle-kit-es/def_config .config
- cp boards/mpfs-icicle-kit-es/def_config .config
The directory boards/mpfs-icicle-kit-es does not exist. defconfigs should only exist in configs
The only defconfig for icicle is
configs/microchip_mpfs_icicle_defconfig
Best regards
Heinrich
-2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will create hss.elf and various binary formats (hss.hex and hss.bin).
On 3/16/21 4:51 AM, Heinrich Schuchardt wrote:
On 11.03.21 02:48, Sean Anderson wrote:
The HSS source uses an "mpfs" prefix with the icicle board name. Change our documentation to match.
Signed-off-by: Sean Anderson seanga2@gmail.com
doc/board/microchip/mpfs_icicle.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/microchip/mpfs_icicle.rst b/doc/board/microchip/mpfs_icicle.rst index c71c2f3cab..cd18472542 100644 --- a/doc/board/microchip/mpfs_icicle.rst +++ b/doc/board/microchip/mpfs_icicle.rst @@ -63,15 +63,15 @@ Build the HSS (Hart Software Services) - Microchip boot-flow
.. code-block:: none
- make BOARD=icicle-kit-es config
make BOARD=mpfs-icicle-kit-es config
Alternatively, copy the default config for Microchip boot-flow.
.. code-block:: none
- cp boards/icicle-kit-es/def_config .config
- cp boards/mpfs-icicle-kit-es/def_config .config
The directory boards/mpfs-icicle-kit-es does not exist. defconfigs should only exist in configs
The only defconfig for icicle is
configs/microchip_mpfs_icicle_defconfig
This is documentation for compiling the HSS [1] for the polarfire SoC.
[1] https://github.com/polarfire-soc/hart-software-services
Best regards
Heinrich
-2. make BOARD=icicle-kit-es +2. make BOARD=mpfs-icicle-kit-es 3. In the Default subdirectory, the standard build will create hss.elf and various binary formats (hss.hex and hss.bin).
participants (4)
-
Bin Meng -
Heinrich Schuchardt -
Padmarao Begari -
Sean Anderson