[U-Boot] [PATCH] net: macb: fix the building warning
fix the following building warning ---8>--- macb.c: In function 'macb_init': macb.c:400:14: warning: 'phydev' may be used uninitialized in this function macb.c:377:21: note: 'phydev' was declared here ---<8---
Signed-off-by: Bo Shen voice.shen@atmel.com
--- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 1f7cc32..90ae42d 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -374,7 +374,7 @@ static int macb_phy_init(struct macb_device *macb) { struct eth_device *netdev = &macb->netdev; #ifdef CONFIG_PHYLIB - struct phy_device *phydev; + struct phy_device *phydev = NULL; #endif u32 ncfgr; u16 phy_id, status, adv, lpa;
Hi Bo,
On 16.08.13 03:46, Bo Shen wrote:
fix the following building warning ---8>--- macb.c: In function 'macb_init': macb.c:400:14: warning: 'phydev' may be used uninitialized in this function macb.c:377:21: note: 'phydev' was declared here ---<8---
Signed-off-by: Bo Shen voice.shen@atmel.com
drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 1f7cc32..90ae42d 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -374,7 +374,7 @@ static int macb_phy_init(struct macb_device *macb) { struct eth_device *netdev = &macb->netdev; #ifdef CONFIG_PHYLIB
- struct phy_device *phydev;
- struct phy_device *phydev = NULL;
NAK, this will deference a NULL pointer later on ...
Best regards
Andreas Bießmann
participants (2)
-
Andreas Bießmann -
Bo Shen