[U-Boot] [PATCH] dm: uclass: Adding missing child_pre_probe description
The comment of child_pre_probe, one of the 'struct uclass_driver' members, is currently missing.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
include/dm/uclass.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/dm/uclass.h b/include/dm/uclass.h index 0e882ce..6e7c1cd 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -58,6 +58,7 @@ struct udevice; * @post_probe: Called after a new device is probed * @pre_remove: Called before a device is removed * @child_post_bind: Called after a child is bound to a device in this uclass + * @child_pre_probe: Called before a child is probed in this uclass * @init: Called to set up the uclass * @destroy: Called to destroy the uclass * @priv_auto_alloc_size: If non-zero this is the size of the private data
On 7 September 2018 at 16:51, Bin Meng bmeng.cn@gmail.com wrote:
The comment of child_pre_probe, one of the 'struct uclass_driver' members, is currently missing.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
include/dm/uclass.h | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
diff --git a/include/dm/uclass.h b/include/dm/uclass.h index 0e882ce..6e7c1cd 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -58,6 +58,7 @@ struct udevice;
- @post_probe: Called after a new device is probed
- @pre_remove: Called before a device is removed
- @child_post_bind: Called after a child is bound to a device in this uclass
- @child_pre_probe: Called before a child is probed in this uclass
I prefer 'a child in this uclass is probed'
- @init: Called to set up the uclass
- @destroy: Called to destroy the uclass
- @priv_auto_alloc_size: If non-zero this is the size of the private data
-- 2.7.4
Hi Simon,
On Fri, Sep 14, 2018 at 6:55 PM Simon Glass sjg@chromium.org wrote:
On 7 September 2018 at 16:51, Bin Meng bmeng.cn@gmail.com wrote:
The comment of child_pre_probe, one of the 'struct uclass_driver' members, is currently missing.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
include/dm/uclass.h | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
diff --git a/include/dm/uclass.h b/include/dm/uclass.h index 0e882ce..6e7c1cd 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -58,6 +58,7 @@ struct udevice;
- @post_probe: Called after a new device is probed
- @pre_remove: Called before a device is removed
- @child_post_bind: Called after a child is bound to a device in this uclass
- @child_pre_probe: Called before a child is probed in this uclass
I prefer 'a child in this uclass is probed'
OK, I will make this change and will include the v2 patch in another related patch series.
Regards, Bin
Hi Bin,
On 15 September 2018 at 06:41, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Fri, Sep 14, 2018 at 6:55 PM Simon Glass sjg@chromium.org wrote:
On 7 September 2018 at 16:51, Bin Meng bmeng.cn@gmail.com wrote:
The comment of child_pre_probe, one of the 'struct uclass_driver' members, is currently missing.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
include/dm/uclass.h | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
diff --git a/include/dm/uclass.h b/include/dm/uclass.h index 0e882ce..6e7c1cd 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -58,6 +58,7 @@ struct udevice;
- @post_probe: Called after a new device is probed
- @pre_remove: Called before a device is removed
- @child_post_bind: Called after a child is bound to a device in this uclass
- @child_pre_probe: Called before a child is probed in this uclass
I prefer 'a child in this uclass is probed'
OK, I will make this change and will include the v2 patch in another related patch series.
Actually I picked this up in the end. I think it is a minor thing.
Applied to u-boot-dm, and now in mainline, thanks!
Regards, Simon
participants (2)
-
Bin Meng -
Simon Glass