Re: [U-Boot] [PATCH 5/5] NAND: DaVinci: allow forced disable of subpage writes

21 Jan 2014


      Dear Murali,
In message 3E54258959B69E4282D79E01AB1F32B70466CE81@DFLE11.ent.ti.com you wrote:
...
...
New CONFIG_ options MUSt be documented in the README.
Will do.
...
Also, you are just adding dead code.  There are no users for this option.
This is a preparatory patch for keystone u-boot port and will bundle with
it if it make more sense. But this looks harmless since this option allow
users to disable subpage write. So I want to merge this right away after 
adding the option name to README. Any issues?
The adding of the documentation to the README and of the code should
be in a single patch, not one after the other.  And the patch should
be art of a series that actually uses this feature.  It has no logical
place in the current patch series.
Best regards,
Wolfgang Denk
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
That Microsoft, the Trabant of the operating  system  world,  may  be
glancing  over the Berlin Wall at the Audis and BMWs and Mercedes. In
their own universe Trabants and Ladas were mainstream too...
                                                   -- Evan Leibovitch

Wolfgang Denk

tags (0)

participants (1)