[U-Boot] [PATCH] malloc: remove extern declarations of malloc_bin_reloc() in board.c files

Declare malloc_bin_reloc() in malloc.h and remove all extern declarations in various board.c files to get rid of one checkpatch.pl warning.
Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@googlemail.com Cc: Wolfgang Denk wd@denx.de Cc: Andreas Bießmann andreas.devel@gmail.com Cc: Jason Jin Jason.jin@freescale.com Cc: Macpaul Lin macpaul@andestech.com Cc: Daniel Hellstrom daniel@gaisler.com --- arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - arch/nds32/lib/board.c | 2 -- arch/sparc/lib/board.c | 1 - include/malloc.h | 1 + 6 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c index b390a6c..676f358 100644 --- a/arch/avr32/lib/board.c +++ b/arch/avr32/lib/board.c @@ -250,7 +250,6 @@ void board_init_f(ulong board_type)
void board_init_r(gd_t *new_gd, ulong dest_addr) { - extern void malloc_bin_reloc (void); #ifndef CONFIG_ENV_IS_NOWHERE extern char * env_name_spec; #endif diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index 65a8595..2add630 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -389,7 +389,6 @@ void board_init_r (gd_t *id, ulong dest_addr) { char *s; bd_t *bd; - extern void malloc_bin_reloc (void);
#ifndef CONFIG_ENV_IS_NOWHERE extern char * env_name_spec; diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c index 59a8001..6a71a6b 100644 --- a/arch/mips/lib/board.c +++ b/arch/mips/lib/board.c @@ -255,7 +255,6 @@ void board_init_r(gd_t *id, ulong dest_addr) #ifndef CONFIG_SYS_NO_FLASH ulong size; #endif - extern void malloc_bin_reloc(void); #ifndef CONFIG_ENV_IS_NOWHERE extern char *env_name_spec; #endif diff --git a/arch/nds32/lib/board.c b/arch/nds32/lib/board.c index 7121313..d834975 100644 --- a/arch/nds32/lib/board.c +++ b/arch/nds32/lib/board.c @@ -305,8 +305,6 @@ void board_init_r(gd_t *id, ulong dest_addr) bd_t *bd; ulong malloc_start;
- extern void malloc_bin_reloc(void); - gd = id; bd = gd->bd;
diff --git a/arch/sparc/lib/board.c b/arch/sparc/lib/board.c index 7e48775..b836cf5 100644 --- a/arch/sparc/lib/board.c +++ b/arch/sparc/lib/board.c @@ -62,7 +62,6 @@ DECLARE_GLOBAL_DATA_PTR; */
extern void timer_interrupt_init(void); -extern void malloc_bin_reloc(void); extern int do_ambapp_print(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]); extern int prom_init(void);
diff --git a/include/malloc.h b/include/malloc.h index ecf3c67..6543f4a 100644 --- a/include/malloc.h +++ b/include/malloc.h @@ -937,6 +937,7 @@ extern ulong mem_malloc_end; extern ulong mem_malloc_brk;
void mem_malloc_init(ulong start, ulong size); +void malloc_bin_reloc(void);
#ifdef __cplusplus }; /* end of extern "C" */

Dear Daniel Schwierzeck,
On 04.06.2012 00:40, Daniel Schwierzeck wrote:
Declare malloc_bin_reloc() in malloc.h and remove all extern declarations in various board.c files to get rid of one checkpatch.pl warning.
Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@googlemail.com Cc: Wolfgang Denk wd@denx.de Cc: Andreas Bießmann andreas.devel@gmail.com
Acked-by: Andreas Bießmann andreas.devel@gmail.com
Cc: Jason Jin Jason.jin@freescale.com Cc: Macpaul Lin macpaul@andestech.com Cc: Daniel Hellstrom daniel@gaisler.com
arch/avr32/lib/board.c | 1 - arch/m68k/lib/board.c | 1 - arch/mips/lib/board.c | 1 - arch/nds32/lib/board.c | 2 -- arch/sparc/lib/board.c | 1 - include/malloc.h | 1 + 6 files changed, 1 insertion(+), 6 deletions(-)

On Sun, Jun 03, 2012 at 12:40:04PM -0000, Daniel Schwierzeck wrote:
Declare malloc_bin_reloc() in malloc.h and remove all extern declarations in various board.c files to get rid of one checkpatch.pl warning.
Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@googlemail.com Cc: Wolfgang Denk wd@denx.de Cc: Andreas Bie?mann andreas.devel@gmail.com Cc: Jason Jin Jason.jin@freescale.com Cc: Macpaul Lin macpaul@andestech.com Cc: Daniel Hellstrom daniel@gaisler.com Acked-by: Andreas Bie?mann andreas.devel@gmail.com
Applied to u-boot/master, thanks!
participants (3)
-
Andreas Bießmann
-
Daniel Schwierzeck
-
Tom Rini