[U-Boot] [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled
Signed-off-by: Udit Agarwal udit.agarwal@nxp.com --- Changes in V2: Corrects commit message. Removes goto label.
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c index 34167cdd50..5b945f5959 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c @@ -795,12 +795,8 @@ enum env_location env_get_location(enum env_operation op, int prio) if (prio) return ENVL_UNKNOWN;
-#ifdef CONFIG_CHAIN_OF_TRUST - /* Check Boot Mode - * If Boot Mode is Secure, return ENVL_NOWHERE - */ - if (fsl_check_boot_mode_secure() == 1) - goto done; +#ifdef CONFIG_ENV_IS_NOWHERE + return env_loc; #endif
switch (src) { @@ -830,9 +826,6 @@ enum env_location env_get_location(enum env_operation op, int prio) break; }
-#ifdef CONFIG_CHAIN_OF_TRUST -done: -#endif return env_loc; } #endif /* CONFIG_TFABOOT */

-----Original Message----- From: Udit Agarwal Sent: Thursday, March 7, 2019 2:55 PM To: u-boot@lists.denx.de Cc: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Ruchika Gupta ruchika.gupta@nxp.com; Jaiprakash Singh jaiprakash.singh@nxp.com; Arun Pathak arun.pathak@nxp.com; Udit Agarwal udit.agarwal@nxp.com Subject: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.
ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled
Signed-off-by: Udit Agarwal udit.agarwal@nxp.com
S /ENVL /ENV
--pk

Hi,
arch/arm/cpu/armv8/fsl-layerscape/cpu.c uses ENVL_NOWHERE to initialize the env_loc enum variable. Shall the ENVL_NOWHERE be replaced with ENV_NOWHERE in commit message.
Regards Udit Agarwal
-----Original Message----- From: Prabhakar Kushwaha Sent: Friday, March 22, 2019 4:32 PM To: Udit Agarwal udit.agarwal@nxp.com; u-boot@lists.denx.de Cc: Ruchika Gupta ruchika.gupta@nxp.com; Jaiprakash Singh jaiprakash.singh@nxp.com; Arun Pathak arun.pathak@nxp.com Subject: RE: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.
-----Original Message----- From: Udit Agarwal Sent: Thursday, March 7, 2019 2:55 PM To: u-boot@lists.denx.de Cc: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Ruchika Gupta ruchika.gupta@nxp.com; Jaiprakash Singh jaiprakash.singh@nxp.com; Arun Pathak arun.pathak@nxp.com; Udit Agarwal udit.agarwal@nxp.com Subject: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.
ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled
Signed-off-by: Udit Agarwal udit.agarwal@nxp.com
S /ENVL /ENV
--pk
participants (2)
-
Prabhakar Kushwaha
-
Udit Agarwal