[U-Boot] [PATCH] buildman: Fix bloat option when 'new' only drops functions

In the case where a new build only decreases sizes and does not increase any size we still want to report what functions have been dropped when doing a bloat comparison.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com --- This is important when doing Kconfig migrations and a given target has only decreased in size, we want to know what was dropped so we can see what needs to be re-enabled. --- tools/buildman/builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index b0ea57ebb4a9..acb0810457e4 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -847,7 +847,7 @@ class Builder: delta.reverse()
args = [add, -remove, grow, -shrink, up, -down, up - down] - if max(args) == 0: + if max(args) == 0 and min(args) == 0: return args = [self.ColourNum(x) for x in args] indent = ' ' * 15

On 22 May 2017 at 11:48, Tom Rini trini@konsulko.com wrote:
In the case where a new build only decreases sizes and does not increase any size we still want to report what functions have been dropped when doing a bloat comparison.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
This is important when doing Kconfig migrations and a given target has only decreased in size, we want to know what was dropped so we can see what needs to be re-enabled.
tools/buildman/builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org

On 22 May 2017 at 11:48, Tom Rini trini@konsulko.com wrote:
In the case where a new build only decreases sizes and does not increase any size we still want to report what functions have been dropped when doing a bloat comparison.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
This is important when doing Kconfig migrations and a given target has only decreased in size, we want to know what was dropped so we can see what needs to be re-enabled.
tools/buildman/builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (3)
-
Simon Glass
-
sjg@google.com
-
Tom Rini