[PATCH] arm: dts: ast2600: Add I2C pinctrl
Set the pinctrl groups for each I2C bus. These are essential to I2C operating correctly.
Signed-off-by: Eddie James eajames@linux.ibm.com --- arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index 64074309b7..ef5b131ac0 100644 --- a/arch/arm/dts/ast2600.dtsi +++ b/arch/arm/dts/ast2600.dtsi @@ -833,6 +833,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1_default>; status = "disabled"; };
@@ -846,6 +848,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c2_default>; status = "disabled"; };
@@ -859,6 +863,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3_default>; };
i2c3: i2c@200 { @@ -871,6 +877,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c4_default>; };
i2c4: i2c@280 { @@ -883,6 +891,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c5_default>; };
i2c5: i2c@300 { @@ -895,6 +905,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c6_default>; };
i2c6: i2c@380 { @@ -907,6 +919,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c7_default>; };
i2c7: i2c@400 { @@ -919,6 +933,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c8_default>; };
i2c8: i2c@480 { @@ -931,6 +947,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c9_default>; };
i2c9: i2c@500 { @@ -943,6 +961,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c10_default>; status = "disabled"; };
@@ -956,6 +976,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c11_default>; status = "disabled"; };
@@ -969,6 +991,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c12_default>; status = "disabled"; };
@@ -982,6 +1006,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c13_default>; status = "disabled"; };
@@ -995,6 +1021,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c14_default>; status = "disabled"; };
@@ -1008,6 +1036,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c15_default>; status = "disabled"; };
@@ -1021,6 +1051,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c16_default>; status = "disabled"; };
@@ -1246,6 +1278,7 @@ function = "I2C1"; groups = "I2C1"; }; + pinctrl_i2c2_default: i2c2_default { function = "I2C2"; groups = "I2C2";
On Wed, 1 Jun 2022 at 16:10, Eddie James eajames@linux.ibm.com wrote:
Set the pinctrl groups for each I2C bus. These are essential to I2C operating correctly.
Signed-off-by: Eddie James eajames@linux.ibm.com
Reviewed-by: Joel Stanley joel@jms.id.au
Thanks Eddie.
arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index 64074309b7..ef5b131ac0 100644 --- a/arch/arm/dts/ast2600.dtsi +++ b/arch/arm/dts/ast2600.dtsi @@ -833,6 +833,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c1_default>; status = "disabled"; };@@ -846,6 +848,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c2_default>; status = "disabled"; };@@ -859,6 +863,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c3_default>; }; i2c3: i2c@200 {@@ -871,6 +877,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c4_default>; }; i2c4: i2c@280 {@@ -883,6 +891,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c5_default>; }; i2c5: i2c@300 {@@ -895,6 +905,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c6_default>; }; i2c6: i2c@380 {@@ -907,6 +919,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c7_default>; }; i2c7: i2c@400 {@@ -919,6 +933,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c8_default>; }; i2c8: i2c@480 {@@ -931,6 +947,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c9_default>; }; i2c9: i2c@500 {@@ -943,6 +961,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c10_default>; status = "disabled"; };@@ -956,6 +976,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c11_default>; status = "disabled"; };@@ -969,6 +991,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c12_default>; status = "disabled"; };@@ -982,6 +1006,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c13_default>; status = "disabled"; };@@ -995,6 +1021,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c14_default>; status = "disabled"; };@@ -1008,6 +1036,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c15_default>; status = "disabled"; };@@ -1021,6 +1051,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c16_default>; status = "disabled"; };@@ -1246,6 +1278,7 @@ function = "I2C1"; groups = "I2C1"; };
pinctrl_i2c2_default: i2c2_default { function = "I2C2"; groups = "I2C2";-- 2.31.1
-----Original Message----- From: Joel Stanley joel@jms.id.au Sent: Thursday, June 2, 2022 11:40 AM To: Eddie James eajames@linux.ibm.com Cc: U-Boot Mailing List u-boot@lists.denx.de; Dylan Hung dylan_hung@aspeedtech.com; Billy Tsai billy_tsai@aspeedtech.com; ChiaWei Wang chiawei_wang@aspeedtech.com; Simon Glass sjg@chromium.org Subject: Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl
On Wed, 1 Jun 2022 at 16:10, Eddie James eajames@linux.ibm.com wrote:
Set the pinctrl groups for each I2C bus. These are essential to I2C operating correctly.
Signed-off-by: Eddie James eajames@linux.ibm.com
Reviewed-by: Joel Stanley joel@jms.id.au
Reviewed-by: Ryan Chen ryan_chen@aspeedtech.com
arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index 64074309b7..ef5b131ac0 100644 --- a/arch/arm/dts/ast2600.dtsi +++ b/arch/arm/dts/ast2600.dtsi @@ -833,6 +833,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c1_default>; status = "disabled"; };@@ -846,6 +848,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c2_default>; status = "disabled"; };@@ -859,6 +863,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c3_default>; }; i2c3: i2c@200 {@@ -871,6 +877,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c4_default>; }; i2c4: i2c@280 {@@ -883,6 +891,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c5_default>; }; i2c5: i2c@300 {@@ -895,6 +905,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c6_default>; }; i2c6: i2c@380 {@@ -907,6 +919,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c7_default>; }; i2c7: i2c@400 {@@ -919,6 +933,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c8_default>; }; i2c8: i2c@480 {@@ -931,6 +947,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c9_default>; }; i2c9: i2c@500 {@@ -943,6 +961,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c10_default>; status = "disabled"; };@@ -956,6 +976,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c11_default>; status = "disabled"; };@@ -969,6 +991,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c12_default>; status = "disabled"; };@@ -982,6 +1006,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c13_default>; status = "disabled"; };@@ -995,6 +1021,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c14_default>; status = "disabled"; };@@ -1008,6 +1036,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c15_default>; status = "disabled"; };@@ -1021,6 +1051,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>;
pinctrl-names = "default";pinctrl-0 = <&pinctrl_i2c16_default>; status = "disabled"; };@@ -1246,6 +1278,7 @@ function = "I2C1"; groups = "I2C1"; };
pinctrl_i2c2_default: i2c2_default { function = "I2C2"; groups = "I2C2";-- 2.31.1
On Wed, Jun 01, 2022 at 11:10:18AM -0500, Eddie James wrote:
Set the pinctrl groups for each I2C bus. These are essential to I2C operating correctly.
Signed-off-by: Eddie James eajames@linux.ibm.com Reviewed-by: Joel Stanley joel@jms.id.au Reviewed-by: Ryan Chen ryan_chen@aspeedtech.com
arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
Sorry for the delay in getting to this patch. I think there's a more general issue right now of needing to get the aspeed trees synced up to the linux kernel, and then synced back down to U-Boot.
participants (4)
-
Eddie James -
Joel Stanley -
Ryan Chen -
Tom Rini