[U-Boot] [PATCH v2] zynq-common: Define spi args offset and size
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com --- Changes for v2: - Moved the configs under SPI-SPL as per review comment. - Updated the commit message with description of the configs. - Placed the kernel offset at 0x200000. - This patch is based on u-boot-spi/master branch --- include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS (CONFIG_SYS_SPI_ARGS_OFFS + \ + CONFIG_SYS_SPI_ARGS_SIZE) #endif
/* for booting directly linux */
On 14 September 2015 at 11:32, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com
Changes for v2:
- Moved the configs under SPI-SPL as per review comment.
- Updated the commit message with description of the configs.
- Placed the kernel offset at 0x200000.
- This patch is based on u-boot-spi/master branch
include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS (CONFIG_SYS_SPI_ARGS_OFFS + \
CONFIG_SYS_SPI_ARGS_SIZE)
Still got SPL build issue
drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe': drivers/mtd/spi/sf_probe.c:480:2: error: dereferencing pointer to incomplete type make[3]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
Does this depends Simon, patches[1] you pointed earlier.
[1] http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-work...
thanks!
Hi Jagan,
-----Original Message----- From: Jagan Teki [mailto:jteki@openedev.com] Sent: Monday, September 14, 2015 1:06 PM To: Siva Durga Prasad Paladugu Cc: u-boot@lists.denx.de; Siva Durga Prasad Paladugu Subject: Re: [PATCH v2] zynq-common: Define spi args offset and size
On 14 September 2015 at 11:32, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com
Changes for v2:
- Moved the configs under SPI-SPL as per review comment.
- Updated the commit message with description of the configs.
- Placed the kernel offset at 0x200000.
- This patch is based on u-boot-spi/master branch
include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS
(CONFIG_SYS_SPI_ARGS_OFFS + \
CONFIG_SYS_SPI_ARGS_SIZE)Still got SPL build issue
drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe': drivers/mtd/spi/sf_probe.c:480:2: error: dereferencing pointer to incomplete type make[3]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
Does this depends Simon, patches[1] you pointed earlier.
[1] http://git.denx.de/?p=u-boot/u-boot- dm.git;a=shortlog;h=refs/heads/zynq-working
Yes it depends on Simon patches.
Thanks, Siva
thanks!
Jagan | openedev.
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Hi Simon,
On 14 September 2015 at 14:06, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Hi Jagan,
-----Original Message----- From: Jagan Teki [mailto:jteki@openedev.com] Sent: Monday, September 14, 2015 1:06 PM To: Siva Durga Prasad Paladugu Cc: u-boot@lists.denx.de; Siva Durga Prasad Paladugu Subject: Re: [PATCH v2] zynq-common: Define spi args offset and size
On 14 September 2015 at 11:32, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com
Changes for v2:
- Moved the configs under SPI-SPL as per review comment.
- Updated the commit message with description of the configs.
- Placed the kernel offset at 0x200000.
- This patch is based on u-boot-spi/master branch
include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS
(CONFIG_SYS_SPI_ARGS_OFFS + \
CONFIG_SYS_SPI_ARGS_SIZE)Still got SPL build issue
drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe': drivers/mtd/spi/sf_probe.c:480:2: error: dereferencing pointer to incomplete type make[3]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
Does this depends Simon, patches[1] you pointed earlier.
[1] http://git.denx.de/?p=u-boot/u-boot- dm.git;a=shortlog;h=refs/heads/zynq-working
Yes it depends on Simon patches.
Any plan to send a PR for this zynq-changes [1]
[1] http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-work...
thanks!
Hi,
On 14 September 2015 at 09:49, Jagan Teki jteki@openedev.com wrote:
Hi Simon,
On 14 September 2015 at 14:06, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Hi Jagan,
-----Original Message----- From: Jagan Teki [mailto:jteki@openedev.com] Sent: Monday, September 14, 2015 1:06 PM To: Siva Durga Prasad Paladugu Cc: u-boot@lists.denx.de; Siva Durga Prasad Paladugu Subject: Re: [PATCH v2] zynq-common: Define spi args offset and size
On 14 September 2015 at 11:32, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com
Changes for v2:
- Moved the configs under SPI-SPL as per review comment.
- Updated the commit message with description of the configs.
- Placed the kernel offset at 0x200000.
- This patch is based on u-boot-spi/master branch
include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS
(CONFIG_SYS_SPI_ARGS_OFFS + \
CONFIG_SYS_SPI_ARGS_SIZE)Still got SPL build issue
drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe': drivers/mtd/spi/sf_probe.c:480:2: error: dereferencing pointer to incomplete type make[3]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
Does this depends Simon, patches[1] you pointed earlier.
[1] http://git.denx.de/?p=u-boot/u-boot- dm.git;a=shortlog;h=refs/heads/zynq-working
Yes it depends on Simon patches.
Any plan to send a PR for this zynq-changes [1]
[1] http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-work...
I felt it was too late for this release. Is anything broken?
Regards, Simon
On 3 October 2015 at 20:00, Simon Glass sjg@chromium.org wrote:
Hi,
On 14 September 2015 at 09:49, Jagan Teki jteki@openedev.com wrote:
Hi Simon,
On 14 September 2015 at 14:06, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Hi Jagan,
-----Original Message----- From: Jagan Teki [mailto:jteki@openedev.com] Sent: Monday, September 14, 2015 1:06 PM To: Siva Durga Prasad Paladugu Cc: u-boot@lists.denx.de; Siva Durga Prasad Paladugu Subject: Re: [PATCH v2] zynq-common: Define spi args offset and size
On 14 September 2015 at 11:32, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:
Define CONFIG_SYS_SPI_ARGS_OFFS, CONFIG_SYS_SPI_ARGS_SIZE and CONFIG_SYS_SPI_KERNEL_OFFS which will be used in SPL spi mode. These macros defines the device tree offset, size and the kernel image offset in flash respectively.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com
Changes for v2:
- Moved the configs under SPI-SPL as per review comment.
- Updated the commit message with description of the configs.
- Placed the kernel offset at 0x200000.
- This patch is based on u-boot-spi/master branch
include/configs/zynq-common.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index f6dd03b..45dafe2 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -355,6 +355,10 @@ #define CONFIG_SPL_SPI_LOAD #define CONFIG_SPL_SPI_FLASH_SUPPORT #define CONFIG_SYS_SPI_U_BOOT_OFFS 0x100000 +#define CONFIG_SYS_SPI_ARGS_OFFS 0x200000 +#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 +#define CONFIG_SYS_SPI_KERNEL_OFFS
(CONFIG_SYS_SPI_ARGS_OFFS + \
CONFIG_SYS_SPI_ARGS_SIZE)Still got SPL build issue
drivers/mtd/spi/sf_probe.c: In function 'spi_flash_std_probe': drivers/mtd/spi/sf_probe.c:480:2: error: dereferencing pointer to incomplete type make[3]: *** [spl/drivers/mtd/spi/sf_probe.o] Error 1
Does this depends Simon, patches[1] you pointed earlier.
[1] http://git.denx.de/?p=u-boot/u-boot- dm.git;a=shortlog;h=refs/heads/zynq-working
Yes it depends on Simon patches.
Any plan to send a PR for this zynq-changes [1]
[1] http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-work...
I felt it was too late for this release. Is anything broken?
Yes, Simon PR[1] is on hold (zynq qspi changes) wrt SPI-SPL. I think Michal is looking on to it,
[1] https://patchwork.ozlabs.org/patch/517709/
-- Jagan.
participants (3)
-
Jagan Teki -
Simon Glass -
Siva Durga Prasad Paladugu