[U-Boot] [PATCH] OMAP3: Zoom2: Fix missing Board and CPU info
With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.
CC: Tom.Rix@windriver.com Signed-off-by: Dirk Behme dirk.behme@googlemail.com ---
Compile tested on recent u-boot next branch.
include/configs/omap3_zoom2.h | 6 ++++++ 1 file changed, 6 insertions(+)
Index: u-boot-main/include/configs/omap3_zoom2.h =================================================================== --- u-boot-main.orig/include/configs/omap3_zoom2.h +++ u-boot-main/include/configs/omap3_zoom2.h @@ -43,6 +43,12 @@ #include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h>
+/* + * Display CPU and Board information + */ +#define CONFIG_DISPLAY_CPUINFO 1 +#define CONFIG_DISPLAY_BOARDINFO 1 + /* Clock Defines */ #define V_OSCK 26000000 /* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
Ok with me. I have verified this patch runs on zoom2. The expected cpu and board info are displayed on startup. Tom
Dirk Behme wrote:
With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.
CC: Tom.Rix@windriver.com Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Compile tested on recent u-boot next branch.
include/configs/omap3_zoom2.h | 6 ++++++ 1 file changed, 6 insertions(+)
Index: u-boot-main/include/configs/omap3_zoom2.h
--- u-boot-main.orig/include/configs/omap3_zoom2.h +++ u-boot-main/include/configs/omap3_zoom2.h @@ -43,6 +43,12 @@ #include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h>
+/*
- Display CPU and Board information
- */
+#define CONFIG_DISPLAY_CPUINFO 1 +#define CONFIG_DISPLAY_BOARDINFO 1
/* Clock Defines */ #define V_OSCK 26000000 /* Clock output from T2 */ #define V_SCLK (V_OSCK >> 1)
On 16:11 Sat 16 May , Dirk Behme wrote:
With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.
It's an option so it's not a fix but you enable each board Maintainer do his own choice
CC: Tom.Rix@windriver.com
please fill with Name <email> as it will be part of the final commit message
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Compile tested on recent u-boot next branch.
include/configs/omap3_zoom2.h | 6 ++++++ 1 file changed, 6 insertions(+)
Index: u-boot-main/include/configs/omap3_zoom2.h
--- u-boot-main.orig/include/configs/omap3_zoom2.h +++ u-boot-main/include/configs/omap3_zoom2.h @@ -43,6 +43,12 @@ #include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap3.h>
+/*
- Display CPU and Board information
- */
+#define CONFIG_DISPLAY_CPUINFO 1 +#define CONFIG_DISPLAY_BOARDINFO 1
it will be good to stop to add the '1' as it's not neccessarely at all
Best Regards, J.
Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:11 Sat 16 May , Dirk Behme wrote:
With other OMAP3 boards we recently switched to CPU and Board info API. From parallel merge, this is missing for Zoom2. Enable it for Zoom2, too.
It's an option so it's not a fix
It is a fix. As mentioned above, we fix the issue "Zoom2 doesn't print CPU and Board info after parallel merge of Zoom2 and OMAP3 switch to Board/CPU info API". With old logic, every OMAP3 board got info output by default. Zoom2, too. With parallel merge of Zoom2 and switch to Board/CPU info API, this was lost for Zoom2. Now we fix this to get the same behavior for Zoom2 as before the Baord/CPU API switch.
Best regards
Dirk
P.S.: Do you have already an idea when we will get the documentation for CPU/Board info API as requested in
http://lists.denx.de/pipermail/u-boot/2009-April/051420.html
(1) ? (Note: (2) was already fixed by Wolfgang)
participants (3)
-
Dirk Behme -
Jean-Christophe PLAGNIOL-VILLARD -
Tom