[U-Boot] [PATCH v2 1/3] i2c: muxes: pca954x: update list of supported devices
The Kconfig help has not been updated while adding PCA9547 and PCA9646.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net
---
Changes v1 -> v2: - add missing comma (Michal) - reword and rewrap the sentence --- drivers/i2c/muxes/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index b0da67ce2c6b..4a601c88b78f 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -29,11 +29,11 @@ config I2C_MUX_PCA954x tristate "TI PCA954x I2C Mux/switches" depends on I2C_MUX help - If you say yes here you get support for the TI PCA954x - I2C mux/switch devices. It is x width I2C multiplexer which enables to - partitioning I2C bus and connect multiple devices with the same address - to the same I2C controller where driver handles proper routing to - target i2c device. PCA9544 and PCA9548 are supported. + If you say yes here you get support for the TI PCA954x I2C mux/switch + devices. It is x width I2C multiplexer which enables to partitioning + I2C bus and connect multiple devices with the same address to the same + I2C controller where driver handles proper routing to target i2c + device. Supported chips are PCA9544, PCA9547, PCA9548 and PCA9646.
config I2C_MUX_GPIO tristate "GPIO-based I2C multiplexer"
The chip_desc.enable field is used only for muxes, not for switches. Document it and remove the unused values.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
---
Changes v1 -> v2: - fix typo in commit message (Michal) --- drivers/i2c/muxes/pca954x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index bd4e9abe5f3c..5669753ce14d 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -22,7 +22,7 @@ enum pca_type { };
struct chip_desc { - u8 enable; + u8 enable; /* Enable mask in ctl register (used for muxes only) */ enum muxtype { pca954x_ismux = 0, pca954x_isswi, @@ -48,12 +48,10 @@ static const struct chip_desc chips[] = { .width = 8, }, [PCA9548] = { - .enable = 0x8, .muxtype = pca954x_isswi, .width = 8, }, [PCA9646] = { - .enable = 0x0, .muxtype = pca954x_isswi, .width = 4, },
On 09. 04. 19 8:57, Luca Ceresoli wrote:
The chip_desc.enable field is used only for muxes, not for switches. Document it and remove the unused values.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- fix typo in commit message (Michal)
drivers/i2c/muxes/pca954x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index bd4e9abe5f3c..5669753ce14d 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -22,7 +22,7 @@ enum pca_type { };
struct chip_desc {
- u8 enable;
- u8 enable; /* Enable mask in ctl register (used for muxes only) */ enum muxtype { pca954x_ismux = 0, pca954x_isswi,
@@ -48,12 +48,10 @@ static const struct chip_desc chips[] = { .width = 8, }, [PCA9548] = {
.enable = 0x8,.enable = 0x0,
Acked-by: Michal Simek michal.simek@xilinx.com
Thanks, Michal
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The chip_desc.enable field is used only for muxes, not for switches. Document it and remove the unused values.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- fix typo in commit message (Michal)
drivers/i2c/muxes/pca954x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Heiko Schocherhs@denx.de
bye, Heiko
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The chip_desc.enable field is used only for muxes, not for switches. Document it and remove the unused values.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- fix typo in commit message (Michal)
drivers/i2c/muxes/pca954x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Applied to u-boot-i2c.git master
Thanks!
bye, Heiko
The PCA9543 is a 2-channel I2C switch.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
---
Changes v1 -> v2: - rebase on current tree --- drivers/i2c/muxes/Kconfig | 3 ++- drivers/i2c/muxes/pca954x.c | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index 4a601c88b78f..68f15261be77 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -33,7 +33,8 @@ config I2C_MUX_PCA954x devices. It is x width I2C multiplexer which enables to partitioning I2C bus and connect multiple devices with the same address to the same I2C controller where driver handles proper routing to target i2c - device. Supported chips are PCA9544, PCA9547, PCA9548 and PCA9646. + device. Supported chips are PCA9543, PCA9544, PCA9547, PCA9548 and + PCA9646.
config I2C_MUX_GPIO tristate "GPIO-based I2C multiplexer" diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index 5669753ce14d..a630ce991d04 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -15,6 +15,7 @@ DECLARE_GLOBAL_DATA_PTR;
enum pca_type { + PCA9543, PCA9544, PCA9547, PCA9548, @@ -37,6 +38,10 @@ struct pca954x_priv { };
static const struct chip_desc chips[] = { + [PCA9543] = { + .muxtype = pca954x_isswi, + .width = 2, + }, [PCA9544] = { .enable = 0x4, .muxtype = pca954x_ismux, @@ -87,6 +92,7 @@ static const struct i2c_mux_ops pca954x_ops = { };
static const struct udevice_id pca954x_ids[] = { + { .compatible = "nxp,pca9543", .data = PCA9543 }, { .compatible = "nxp,pca9544", .data = PCA9544 }, { .compatible = "nxp,pca9547", .data = PCA9547 }, { .compatible = "nxp,pca9548", .data = PCA9548 },
On 09. 04. 19 8:57, Luca Ceresoli wrote:
The PCA9543 is a 2-channel I2C switch.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- rebase on current tree
drivers/i2c/muxes/Kconfig | 3 ++- drivers/i2c/muxes/pca954x.c | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index 4a601c88b78f..68f15261be77 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -33,7 +33,8 @@ config I2C_MUX_PCA954x devices. It is x width I2C multiplexer which enables to partitioning I2C bus and connect multiple devices with the same address to the same I2C controller where driver handles proper routing to target i2c
device. Supported chips are PCA9544, PCA9547, PCA9548 and PCA9646.
device. Supported chips are PCA9543, PCA9544, PCA9547, PCA9548 andPCA9646.config I2C_MUX_GPIO tristate "GPIO-based I2C multiplexer" diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index 5669753ce14d..a630ce991d04 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -15,6 +15,7 @@ DECLARE_GLOBAL_DATA_PTR;
enum pca_type {
- PCA9543, PCA9544, PCA9547, PCA9548,
@@ -37,6 +38,10 @@ struct pca954x_priv { };
static const struct chip_desc chips[] = {
- [PCA9543] = {
.muxtype = pca954x_isswi,.width = 2,- }, [PCA9544] = { .enable = 0x4, .muxtype = pca954x_ismux,
@@ -87,6 +92,7 @@ static const struct i2c_mux_ops pca954x_ops = { };
static const struct udevice_id pca954x_ids[] = {
- { .compatible = "nxp,pca9543", .data = PCA9543 }, { .compatible = "nxp,pca9544", .data = PCA9544 }, { .compatible = "nxp,pca9547", .data = PCA9547 }, { .compatible = "nxp,pca9548", .data = PCA9548 },
Acked-by: Michal Simek michal.simek@xilinx.com
Thanks, Michal
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The PCA9543 is a 2-channel I2C switch.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- rebase on current tree
drivers/i2c/muxes/Kconfig | 3 ++- drivers/i2c/muxes/pca954x.c | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Heiko Schocherhs@denx.de
bye, Heiko
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The PCA9543 is a 2-channel I2C switch.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net Reviewed-by: Heiko Schocher hs@denx.de
Changes v1 -> v2:
- rebase on current tree
drivers/i2c/muxes/Kconfig | 3 ++- drivers/i2c/muxes/pca954x.c | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
Applied to u-boot-i2c.git master
Thanks!
bye, Heiko
On 09. 04. 19 8:57, Luca Ceresoli wrote:
The Kconfig help has not been updated while adding PCA9547 and PCA9646.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net
Changes v1 -> v2:
- add missing comma (Michal)
- reword and rewrap the sentence
drivers/i2c/muxes/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index b0da67ce2c6b..4a601c88b78f 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -29,11 +29,11 @@ config I2C_MUX_PCA954x tristate "TI PCA954x I2C Mux/switches" depends on I2C_MUX help
If you say yes here you get support for the TI PCA954xI2C mux/switch devices. It is x width I2C multiplexer which enables topartitioning I2C bus and connect multiple devices with the same addressto the same I2C controller where driver handles proper routing totarget i2c device. PCA9544 and PCA9548 are supported.
If you say yes here you get support for the TI PCA954x I2C mux/switchdevices. It is x width I2C multiplexer which enables to partitioningI2C bus and connect multiple devices with the same address to the sameI2C controller where driver handles proper routing to target i2cdevice. Supported chips are PCA9544, PCA9547, PCA9548 and PCA9646.config I2C_MUX_GPIO tristate "GPIO-based I2C multiplexer"
Acked-by: Michal Simek michal.simek@xilinx.com
Thanks, Michal
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The Kconfig help has not been updated while adding PCA9547 and PCA9646.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net
Changes v1 -> v2:
- add missing comma (Michal)
- reword and rewrap the sentence
drivers/i2c/muxes/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Heiko Schocherhs@denx.de
bye, Heiko
Hello Luca,
Am 09.04.2019 um 08:57 schrieb Luca Ceresoli:
The Kconfig help has not been updated while adding PCA9547 and PCA9646.
Signed-off-by: Luca Ceresoli luca@lucaceresoli.net
Changes v1 -> v2:
- add missing comma (Michal)
- reword and rewrap the sentence
drivers/i2c/muxes/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Applied to u-boot-i2c.git master
Thanks!
bye, Heiko
participants (3)
-
Heiko Schocher -
Luca Ceresoli -
Michal Simek