[PATCH v2 1/2] spl: remove duplicate SPL_MD5 option
There is another SPL_MD5 option defined in lib/Kconfig. Renaming SPL_MD5_SUPPORT introduced duplicate option with different description. As for now FIT and hash algorithm options are not related to each others, removing a duplicate option seems OK.
Fixes: 4b00fd1a84c ("Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5") Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io ---
(no changes since v1)
common/spl/Kconfig | 12 ------------ 1 file changed, 12 deletions(-)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index bee231b583a..c66d70e2a99 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -561,18 +561,6 @@ config SPL_CRC32 for detected accidental image corruption. For secure applications you should consider SHA1 or SHA256.
-config SPL_MD5 - bool "Support MD5" - depends on SPL_FIT - help - Enable this to support MD5 in FIT images within SPL. An MD5 - checksum is a 128-bit hash value used to check that the image - contents have not been corrupted. Note that MD5 is not considered - secure as it is possible (with a brute-force attack) to adjust the - image while still retaining the same MD5 hash value. For secure - applications where images may be changed maliciously, you should - consider SHA256 or SHA384. - config SPL_FIT_IMAGE_TINY bool "Remove functionality from SPL FIT loading to reduce size" depends on SPL_FIT
All SPL hash algorithm options are collected in lib/Kconfig. Move SPL_CRC32 there as well.
Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io ---
Changes in v2: - add a related commit to the series.
common/spl/Kconfig | 11 ----------- lib/Kconfig | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index c66d70e2a99..c5dd476db58 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -550,17 +550,6 @@ config SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION the eMMC EXT_CSC_PART_CONFIG selection should be overridden in SPL by user defined partition number.
-config SPL_CRC32 - bool "Support CRC32" - default y if SPL_LEGACY_IMAGE_FORMAT || SPL_EFI_PARTITION - default y if SPL_ENV_SUPPORT || TPL_BLOBLIST - help - Enable this to support CRC32 in uImages or FIT images within SPL. - This is a 32-bit checksum value that can be used to verify images. - For FIT images, this is the least secure type of checksum, suitable - for detected accidental image corruption. For secure applications you - should consider SHA1 or SHA256. - config SPL_FIT_IMAGE_TINY bool "Remove functionality from SPL FIT loading to reduce size" depends on SPL_FIT diff --git a/lib/Kconfig b/lib/Kconfig index 3926652db63..07e61de5b64 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -534,6 +534,17 @@ config SHA_HW_ACCEL
if SPL
+config SPL_CRC32 + bool "Enable CRC32 support in SPL" + default y if SPL_LEGACY_IMAGE_SUPPORT || SPL_EFI_PARTITION + default y if SPL_ENV_SUPPORT || TPL_BLOBLIST + help + This option enables support of hashing using CRC32 algorithm. + The CRC32 algorithm produces 32-bit checksum value. For FIT + images, this is the least secure type of checksum, suitable for + detected accidental image corruption. For secure applications you + should consider SHA256 or SHA384. + config SPL_SHA1 bool "Enable SHA1 support in SPL" default y if SHA1
On Thu, 3 Aug 2023 at 10:05, Oleksandr Suvorov oleksandr.suvorov@foundries.io wrote:
All SPL hash algorithm options are collected in lib/Kconfig. Move SPL_CRC32 there as well.
Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io
Changes in v2:
- add a related commit to the series.
common/spl/Kconfig | 11 ----------- lib/Kconfig | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Thu, Aug 03, 2023 at 07:05:40PM +0300, Oleksandr Suvorov wrote:
All SPL hash algorithm options are collected in lib/Kconfig. Move SPL_CRC32 there as well.
Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
On Thu, Aug 03, 2023 at 07:05:39PM +0300, Oleksandr Suvorov wrote:
There is another SPL_MD5 option defined in lib/Kconfig. Renaming SPL_MD5_SUPPORT introduced duplicate option with different description. As for now FIT and hash algorithm options are not related to each others, removing a duplicate option seems OK.
Fixes: 4b00fd1a84c ("Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5") Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io
Applied to u-boot/master, thanks!
participants (3)
-
Oleksandr Suvorov -
Simon Glass -
Tom Rini