[U-Boot-Users] New! Improved! [PATCHES] For The 8540ADS/8560ADS
Wolfgang,
The enclosed patch, MPC85XXADS-20040617-diffs.tgz, should clean up the remaining issues from my previous patches for the 8540ADS and 8560ADS boards. These patches are relative to the top of CVS on 15-June-2004.
It should address some of your concerns as well. Please let me know if you need any other fixes.
Thanks, jdl
* Patches by Jon Loeliger, 17 June 2004: Completion of the 8540ADS/8560ADS updates from 11 May 2004 Fixes some PCI and Rapid I/O memory maps Initializes both TSEC 1 and 2 Initializes SDRAM Update MAINTAINER for 85xx boards and README.mpc85xxads
In message 1087513856.15094.12.camel@blarg.somerset.sps.mot.com you wrote:
The enclosed patch, MPC85XXADS-20040617-diffs.tgz, should clean up the remaining issues from my previous patches for the 8540ADS and 8560ADS boards. These patches are relative to the top of CVS on 15-June-2004.
It should address some of your concerns as well. Please let me know if you need any other fixes.
Please stick to the Coding Style:
Don't add trailing white space! Use TAB for indentation, not spaces. Indentation is always 8 columns (a TAB).
I reject the following parts:
cpu/mpc85xx/spd_sdram.c:
Don't create redundand code. No need to introduce a new macro DEB() if there is already debug() which does the same, just better.
If there were any other changes to this file than this and bogus reformatting they are lost.
And... please: don't create a tarball for just a single file. Simply gzipping it is not more work for you and less work for me.
All the rest: added & checked in.
Best regards,
Wolfgang Denk
participants (2)
-
Jon Loeliger -
Wolfgang Denk