[PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it.
Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- .../asm/arch-tangier/acpi/southcluster.asl | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl index 01077293bb91..41facdde6a3d 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl @@ -97,6 +97,38 @@ Device (PCI0) } }
+ Device (SDHB) + { + Name (_ADR, 0x00010002) + Name (_DEP, Package () + { + GPIO + }) + + Name (RBUF, ResourceTemplate() + { + GpioInt(Edge, ActiveBoth, SharedAndWake, PullNone, 10000, + "\_SB.PCI0.GPIO", 0, ResourceConsumer, , ) { 77 } + }) + + Method (_CRS, 0, Serialized) + { + Return (RBUF) + } + + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "cd-gpios", Package () { ^SDHB, 0, 0, 0 } }, + } + }) + + Method (_STA) + { + Return (STA_VISIBLE) + } + } + Device (SDHC) { Name (_ADR, 0x00010003)
On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it.
Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
.../asm/arch-tangier/acpi/southcluster.asl | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)
Acked-by: Bin Meng bmeng.cn@gmail.com
On Fri, Sep 10, 2021 at 2:38 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it.
Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
.../asm/arch-tangier/acpi/southcluster.asl | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)
Acked-by: Bin Meng bmeng.cn@gmail.com
Thanks!
I think I need to adjust the IRQ flags, i.e. to put it as Exclusive and Wake. So I'll send a v2, but I'll keep your tag, I hope that's fine.
On Sat, Sep 11, 2021 at 12:07 AM Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Fri, Sep 10, 2021 at 2:38 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it.
Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
.../asm/arch-tangier/acpi/southcluster.asl | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)
Acked-by: Bin Meng bmeng.cn@gmail.com
Thanks!
I think I need to adjust the IRQ flags, i.e. to put it as Exclusive and Wake. So I'll send a v2, but I'll keep your tag, I hope that's fine.
Sure!
On Fri, Sep 10, 2021 at 7:16 PM Bin Meng bmeng.cn@gmail.com wrote:
On Sat, Sep 11, 2021 at 12:07 AM Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Fri, Sep 10, 2021 at 2:38 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it.
Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
.../asm/arch-tangier/acpi/southcluster.asl | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)
Acked-by: Bin Meng bmeng.cn@gmail.com
Thanks!
I think I need to adjust the IRQ flags, i.e. to put it as Exclusive and Wake. So I'll send a v2, but I'll keep your tag, I hope that's fine.
Sure!
Thinkg more about it. Intel Edison is a DIY-ish module and perhaps not everybody want to use SD card or (since there are not so many GPIOs are made out for use) take SD CD exclusively for it. So, I think the initial intention is better, But what I would change is a bias to be PullUp dues to some PCB misconfigurations (no external PU resistor). v2 soon on its way.
participants (3)
-
Andy Shevchenko -
Andy Shevchenko -
Bin Meng