[U-Boot] [PATCH] scsi: ceva: Start port in probe

The patch: "dm: ahci: Unwind the confusing init code" (sha1: 7cf1afce7fa3fe64189020fe14b93f7326dd0758) introduce bug for ceva sata because port didn't start. On the other hand the dwc_ahci.c was fixed correctly. Do the same change for ceva too.
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
drivers/ata/sata_ceva.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_ceva.c b/drivers/ata/sata_ceva.c index d582e5ba80f0..3ef7b49215c4 100644 --- a/drivers/ata/sata_ceva.c +++ b/drivers/ata/sata_ceva.c @@ -113,11 +113,16 @@ static int ceva_init_sata(ulong mmio)
static int sata_ceva_probe(struct udevice *dev) { + int ret; struct scsi_platdata *plat = dev_get_uclass_platdata(dev);
ceva_init_sata(plat->base);
- return achi_init_one_dm(dev); + ret = achi_init_one_dm(dev); + if (ret) + return ret; + + return achi_start_ports_dm(dev); }
static const struct udevice_id sata_ceva_ids[] = {

On 11/02/2017 03:53 PM, Michal Simek wrote:
The patch: "dm: ahci: Unwind the confusing init code" (sha1: 7cf1afce7fa3fe64189020fe14b93f7326dd0758) introduce bug for ceva sata because port didn't start. On the other hand the dwc_ahci.c was fixed correctly. Do the same change for ceva too.
Signed-off-by: Michal Simekmichal.simek@xilinx.com
Thanks Michal!
Tested-by: Mian Yousaf Kaukab yousaf.kaukab@suse.com

On 2 November 2017 at 08:53, Michal Simek michal.simek@xilinx.com wrote:
The patch: "dm: ahci: Unwind the confusing init code" (sha1: 7cf1afce7fa3fe64189020fe14b93f7326dd0758) introduce bug for ceva sata because port didn't start. On the other hand the dwc_ahci.c was fixed correctly. Do the same change for ceva too.
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/ata/sata_ceva.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
participants (3)
-
Mian Yousaf Kaukab
-
Michal Simek
-
Simon Glass