Re: [PATCH 06/11] imx: ventana: convert U-Boot to OF_CONTROL using FIT image

On Thu, Apr 8, 2021 at 1:57 PM sbabic@denx.de wrote:
In preparation for dm conversion convert to OF_CONTROL by adding FIT image support and multi dtb. Add a board_fit_config_name_match to match the dtb based off of EEPROM model. Signed-off-by: Tim Harvey tharvey@gateworks.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Stefano,
Something broke apparently between the branch I had my patches on top of and u-boot-imx/master that these got merged in. My board is hanging at dram_init_banksize - did something change recently that you are aware of that may require some changes on my end?
Thanks,
Tim

Hi Tim,
On 09.04.21 21:52, Tim Harvey wrote:
On Thu, Apr 8, 2021 at 1:57 PM sbabic@denx.de wrote:
In preparation for dm conversion convert to OF_CONTROL by adding FIT image support and multi dtb. Add a board_fit_config_name_match to match the dtb based off of EEPROM model. Signed-off-by: Tim Harvey tharvey@gateworks.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Stefano,
Something broke apparently between the branch I had my patches on top of and u-boot-imx/master that these got merged in. My board is hanging at dram_init_banksize - did something change recently that you are aware of that may require some changes on my end?
There are a lot of changes, but they are related to i.MX8. I have not merged something for i.MX6 that can justify this behavior. So I do not know - have you compared the two branches, at least for Ventana boards ?
Stefano
Thanks,
Tim

On Fri, Apr 9, 2021 at 1:00 PM Stefano Babic sbabic@denx.de wrote:
Hi Tim,
On 09.04.21 21:52, Tim Harvey wrote:
On Thu, Apr 8, 2021 at 1:57 PM sbabic@denx.de wrote:
In preparation for dm conversion convert to OF_CONTROL by adding FIT image support and multi dtb. Add a board_fit_config_name_match to match the dtb based off of EEPROM model. Signed-off-by: Tim Harvey tharvey@gateworks.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Stefano,
Something broke apparently between the branch I had my patches on top of and u-boot-imx/master that these got merged in. My board is hanging at dram_init_banksize - did something change recently that you are aware of that may require some changes on my end?
There are a lot of changes, but they are related to i.MX8. I have not merged something for i.MX6 that can justify this behavior. So I do not know - have you compared the two branches, at least for Ventana boards ?
It's hanging at arch/arm/mach-imx/spl.c:dram_init_banksize on 'gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE' so I suppose something is wrong with gd.
I'll have to compare branches as you suggest.
Tim

On Fri, Apr 9, 2021 at 1:08 PM Tim Harvey tharvey@gateworks.com wrote:
On Fri, Apr 9, 2021 at 1:00 PM Stefano Babic sbabic@denx.de wrote:
Hi Tim,
On 09.04.21 21:52, Tim Harvey wrote:
On Thu, Apr 8, 2021 at 1:57 PM sbabic@denx.de wrote:
In preparation for dm conversion convert to OF_CONTROL by adding FIT image support and multi dtb. Add a board_fit_config_name_match to match the dtb based off of EEPROM model. Signed-off-by: Tim Harvey tharvey@gateworks.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Stefano,
Something broke apparently between the branch I had my patches on top of and u-boot-imx/master that these got merged in. My board is hanging at dram_init_banksize - did something change recently that you are aware of that may require some changes on my end?
There are a lot of changes, but they are related to i.MX8. I have not merged something for i.MX6 that can justify this behavior. So I do not know - have you compared the two branches, at least for Ventana boards ?
It's hanging at arch/arm/mach-imx/spl.c:dram_init_banksize on 'gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE' so I suppose something is wrong with gd.
specifically gd->bd is NULL. I'll have to track down how that gets setup.
Tim

On Fri, Apr 9, 2021 at 1:14 PM Tim Harvey tharvey@gateworks.com wrote:
On Fri, Apr 9, 2021 at 1:08 PM Tim Harvey tharvey@gateworks.com wrote:
On Fri, Apr 9, 2021 at 1:00 PM Stefano Babic sbabic@denx.de wrote:
Hi Tim,
On 09.04.21 21:52, Tim Harvey wrote:
On Thu, Apr 8, 2021 at 1:57 PM sbabic@denx.de wrote:
In preparation for dm conversion convert to OF_CONTROL by adding FIT image support and multi dtb. Add a board_fit_config_name_match to match the dtb based off of EEPROM model. Signed-off-by: Tim Harvey tharvey@gateworks.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
Stefano,
Something broke apparently between the branch I had my patches on top of and u-boot-imx/master that these got merged in. My board is hanging at dram_init_banksize - did something change recently that you are aware of that may require some changes on my end?
There are a lot of changes, but they are related to i.MX8. I have not merged something for i.MX6 that can justify this behavior. So I do not know - have you compared the two branches, at least for Ventana boards ?
It's hanging at arch/arm/mach-imx/spl.c:dram_init_banksize on 'gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE' so I suppose something is wrong with gd.
specifically gd->bd is NULL. I'll have to track down how that gets setup.
Stefano,
commit 38d6b7ebdaee ("spl: Drop bd_info in the data section") is the culprit which breaks IMX boards using SPL that don't define SPL_ALLOC_BD. There is another thread regarding if that commit should be reverted or if instead it can be fixed (ie by defining SPL_ALLOC_BD) so probably not worth discussing in this thread anymore.
Best regards,
Tim
participants (2)
-
Stefano Babic
-
Tim Harvey