Re: [U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270
stefano babic <sbabic <at> denx.de> writes:
Code is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in pxa-regs.h
Signed-off-by: Stefano Babic <sbabic <at> denx.de>
This Patch makes wrong calculation!
The real bug can be fixed by using the old style with pointer / address (from the linux kernel)
#define GPLR(x) (*((((x) & 0x7f) < 96) ? &_GPLR(x) : &GPLR3))
or by fixing the calculation
#define GPLR(x) __REG2(0x40E00000, (((x) & 0x7f) < 96) ? ((x) & 0x60) >> 3 : 0x100)
Which is the preferred way?
Stefan
In message 4784AFAE.3080505@hni.uni-paderborn.de you wrote:
stefano babic <sbabic <at> denx.de> writes:
Code is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in pxa-regs.h
Signed-off-by: Stefano Babic <sbabic <at> denx.de>
This Patch makes wrong calculation!
Which specific patch are you referring to? I think what you refer to has been obsoleted by Stefnao's postings on Nov 11:
11/20 stefano babic [U-Boot-Users] [PATCH] Fix gcc issues in pxa-regs.h
Best regards,
Wolfgang Denk
Sorry, I don't know this patch and I only saw, that it was not fix in version 1.3.1 or the git tree.
Stefan
Wolfgang Denk schrieb:
In message 4784AFAE.3080505@hni.uni-paderborn.de you wrote:
stefano babic <sbabic <at> denx.de> writes:
Code is broken for PXA270 due to "invalid lvalue in assignment".
This patch fix it in pxa-regs.h
Signed-off-by: Stefano Babic <sbabic <at> denx.de>
This Patch makes wrong calculation!
Which specific patch are you referring to? I think what you refer to has been obsoleted by Stefnao's postings on Nov 11:
11/20 stefano babic [U-Boot-Users] [PATCH] Fix gcc issues in pxa-regs.h
Best regards,
Wolfgang Denk
participants (2)
-
Stefan Herbrechtsmeier -
Wolfgang Denk