Re: [U-Boot] [PATCH 6/8] nhk8815: added keypad
Dear Alessandro Rubini,
In message <5a9bb8fb15cdb47d2ccd77af62f759ed493de944.1255086085.git.rubini@ unipv.it> you wrote:
From: Alessandro Rubini rubini@unipv.it
Signed-off-by: Alessandro Rubini rubini@unipv.it Acked-by: Andrea Gallo andrea.gallo@stericsson.com
Please see previous comments about coding style.
Additionally:
+int nhk8815_keypad_init(void) +{
struct stdio_dev dev;
Indentation by TAB only, please.
- printf("%s:%s\n", __FILE__, __func__);
Guess this should be debug() instead?
Best regards,
Wolfgang Denk
Hello Wolfgang.
Thanks for looking at my patch-set.
- printf("%s:%s\n", __FILE__, __func__);
Guess this should be debug() instead?
Actually, this was meant to be removed in final code. As explained in the 0/8 message, this patch set was mainly and RFC, as some of the stuff looked questionable to me. So I chose to post my current status to get some comments on the approach, not on the details which I know were just work in progress, though working on real hardware.
So, unless there are serious issues, I'll clean up my current tree, add comments to each patch and repost as V2.
thanks /alessandro
participants (2)
-
Alessandro Rubini -
Wolfgang Denk