[PATCH] Revert "cli_readline: Only insert printable chars"

This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by: Pali Rohár pali@kernel.org --- common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/cli_readline.c b/common/cli_readline.c index f6e2bcdeceb2..d6444f5fc1d3 100644 --- a/common/cli_readline.c +++ b/common/cli_readline.c @@ -517,10 +517,8 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len, } #endif default: - if (ichar >= ' ' && ichar <= '~') { - cread_add_char(ichar, insert, &num, &eol_num, - buf, *len); - } + cread_add_char(ichar, insert, &num, &eol_num, buf, + *len); break; } }

On Tue, 1 Nov 2022 at 17:42, Pali Rohár pali@kernel.org wrote:
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by: Pali Rohár pali@kernel.org
common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Tuesday 01 November 2022 21:07:24 Simon Glass wrote:
On Tue, 1 Nov 2022 at 17:42, Pali Rohár pali@kernel.org wrote:
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by: Pali Rohár pali@kernel.org
common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Hello! Any objection? If not, could you take this patch?

On Wed, Nov 02, 2022 at 12:40:46AM +0100, Pali Rohár wrote:
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by: Pali Rohár pali@kernel.org Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Pali Rohár
-
Simon Glass
-
Tom Rini