[U-Boot] [PATCH] board/t1024rdb: enable board-level reset when issuing reset command
As board-specific reset logic, it needs to issue reset signal via CPLD when issuing 'reset' command in u-boot, this patch solves the issue of reset command not working on T1024RDB.
Signed-off-by: Shengzhou Liu Shengzhou.Liu@nxp.com --- board/freescale/t102xrdb/t102xrdb.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/board/freescale/t102xrdb/t102xrdb.c b/board/freescale/t102xrdb/t102xrdb.c index 56f7c1a..f370f72 100644 --- a/board/freescale/t102xrdb/t102xrdb.c +++ b/board/freescale/t102xrdb/t102xrdb.c @@ -167,6 +167,13 @@ unsigned long get_board_ddr_clk(void) return CONFIG_DDR_CLK_FREQ; }
+#ifdef CONFIG_TARGET_T1024RDB +void board_reset(void) +{ + CPLD_WRITE(reset_ctl1, CPLD_LBMAP_RESET); +} +#endif + int misc_init_r(void) { return 0;
On 04/10/2017 01:14 AM, Shengzhou Liu wrote:
As board-specific reset logic, it needs to issue reset signal via CPLD when issuing 'reset' command in u-boot, this patch solves the issue of reset command not working on T1024RDB.
Shengzhou,
Doesn't the RST_REQ signal work for this board?
York
-----Original Message----- From: York Sun [mailto:york.sun@nxp.com] Sent: Tuesday, April 11, 2017 1:14 AM To: Shengzhou Liu shengzhou.liu@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH] board/t1024rdb: enable board-level reset when issuing reset command
On 04/10/2017 01:14 AM, Shengzhou Liu wrote:
As board-specific reset logic, it needs to issue reset signal via CPLD when issuing 'reset' command in u-boot, this patch solves the issue of reset command not working on T1024RDB.
Shengzhou,
Doesn't the RST_REQ signal work for this board?
York
York,
Yes, RST_REQ can't reliably work without CPLD reset on T1024RDB, it needs a board-level reset via CPLD reset logic.
Shengzhou
On 04/11/2017 02:16 AM, Shengzhou Liu wrote:
-----Original Message----- From: York Sun [mailto:york.sun@nxp.com] Sent: Tuesday, April 11, 2017 1:14 AM To: Shengzhou Liu shengzhou.liu@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH] board/t1024rdb: enable board-level reset when issuing reset command
On 04/10/2017 01:14 AM, Shengzhou Liu wrote:
As board-specific reset logic, it needs to issue reset signal via CPLD when issuing 'reset' command in u-boot, this patch solves the issue of reset command not working on T1024RDB.
Shengzhou,
Doesn't the RST_REQ signal work for this board?
York
York,
Yes, RST_REQ can't reliably work without CPLD reset on T1024RDB, it needs a board-level reset via CPLD reset logic.
Why? Isn't it a hardware problem? If this is something cannot be fixed, we can add this as a software workaround. Let's make it clear.
York
On 04/10/2017 01:14 AM, Shengzhou Liu wrote:
As board-specific reset logic, it needs to issue reset signal via CPLD when issuing 'reset' command in u-boot, this patch solves the issue of reset command not working on T1024RDB.
Signed-off-by: Shengzhou Liu Shengzhou.Liu@nxp.com
Applied to u-boot-fsl-qoriq master, awaiting upstream. Thanks.
York
participants (3)
-
Shengzhou Liu -
Shengzhou Liu
-
York Sun