[U-Boot-Users] [PATCH] BUGFIX: serial setting for kgdb

Hi,
KGDB_SMC_INDEX must be used as the index for brg_map, but it is used direclty. (compared with function serial_init) So it does not work properly. I have tested it and it works fine.
I noticed the same problem with 'serial_scc.c', but I could not test it yet.
Patch for only for 'serial_smc.c' is attached.
Index: cpu/mpc8260/serial_smc.c =================================================================== --- cpu/mpc8260/serial_smc.c (revision 65) +++ cpu/mpc8260/serial_smc.c (working copy) @@ -360,10 +360,10 @@ /* Set up the baud rate generator. */ #if defined(CONFIG_KGDB_USE_EXTC) - m8260_cpm_extcbrg(KGDB_SMC_INDEX, speed, + m8260_cpm_extcbrg(brg_map[KGDB_SMC_INDEX], speed, CONFIG_KGDB_EXTC_RATE, CONFIG_KGDB_EXTC_PINSEL); #else - m8260_cpm_setbrg(KGDB_SMC_INDEX, speed); + m8260_cpm_setbrg(brg_map[KGDB_SMC_INDEX], speed); #endif
/* Make the first buffer the only buffer.

In message 41BA5DAC.9000008@yahoo.co.kr you wrote:
KGDB_SMC_INDEX must be used as the index for brg_map, but it is used direclty. (compared with function serial_init) So it does not work properly. I have tested it and it works fine.
Thanks for pointing out, added.
I noticed the same problem with 'serial_scc.c', but I could not test it yet.
I think the serial_scc.c code is OK, please check again.
Best regards,
Wolfgang Denk
participants (2)
-
HoJin
-
Wolfgang Denk