[U-Boot] [PATCH] test/py: Add option to skip SPL signature checking
Provide user option to skip SPL signature verification for cases where u-boot is build with SPL support but full U-Boot is also verified without SPL. If you want to support this feature please add env__spl_skipped = True to your boardenv configuration file.
For example Xilinx Zynq is using this feature where the same u-boot binary is checked with SPL and without SPL(with FSBL).
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
test/py/u_boot_console_base.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py index d6502c6e64cb..e50885d51aa4 100644 --- a/test/py/u_boot_console_base.py +++ b/test/py/u_boot_console_base.py @@ -307,7 +307,9 @@ class ConsoleBase(object): config_spl = bcfg.get('config_spl', 'n') == 'y' config_spl_serial_support = bcfg.get('config_spl_serial_support', 'n') == 'y' - if config_spl and config_spl_serial_support: + config_spl_skip = self.config.env.get('env__spl_skipped', + False) + if config_spl and config_spl_serial_support and not config_spl_skip: m = self.p.expect([pattern_u_boot_spl_signon] + self.bad_patterns) if m != 0:
On 02/22/2016 05:52 AM, Michal Simek wrote:
Provide user option to skip SPL signature verification for cases where u-boot is build with SPL support but full U-Boot is also verified without SPL. If you want to support this feature please add env__spl_skipped = True to your boardenv configuration file.
Nit: Blank line between those paragraphs?
For example Xilinx Zynq is using this feature where the same u-boot binary is checked with SPL and without SPL(with FSBL).
Nit: U-Boot not u-boot?
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
config_spl = bcfg.get('config_spl', 'n') == 'y' config_spl_serial_support = bcfg.get('config_spl_serial_support', 'n') == 'y'
if config_spl and config_spl_serial_support:
config_spl_skip = self.config.env.get('env__spl_skipped',False)
That's not a config file (.config or autoconf.mk), but a boardenv value. I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.
Tested-by: Stephen Warren swarren@nvidia.com
Once renamed, Acked-by: Stephen Warren swarren@nvidia.com
On 22.2.2016 18:29, Stephen Warren wrote:
On 02/22/2016 05:52 AM, Michal Simek wrote:
Provide user option to skip SPL signature verification for cases where u-boot is build with SPL support but full U-Boot is also verified without SPL. If you want to support this feature please add env__spl_skipped = True to your boardenv configuration file.
Nit: Blank line between those paragraphs?
fixed
For example Xilinx Zynq is using this feature where the same u-boot binary is checked with SPL and without SPL(with FSBL).
Nit: U-Boot not u-boot?
fixed.
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
config_spl = bcfg.get('config_spl', 'n') == 'y' config_spl_serial_support =bcfg.get('config_spl_serial_support', 'n') == 'y'
if config_spl and config_spl_serial_support:
config_spl_skip = self.config.env.get('env__spl_skipped',False)That's not a config file (.config or autoconf.mk), but a boardenv value. I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.
env_spl_skipped is used now. Currently env__net_dhcp_server names are used. It is also board specific. Maybe make sense to just rename all these to boardenv_XXX.
Tested-by: Stephen Warren swarren@nvidia.com
Once renamed, Acked-by: Stephen Warren swarren@nvidia.com
I have added to v2 but feel free to reply if I should do any change.
Thanks, Michal
participants (2)
-
Michal Simek -
Stephen Warren