Re: [U-Boot] [RFC] MAKEALL: Fix case substitution for old bash
+U-Boot
Hi Allen, York,
On Fri, Mar 29, 2013 at 11:05 AM, Allen Martin amartin@nvidia.com wrote:
On Fri, Mar 29, 2013 at 10:56:33AM -0700, York Sun wrote:
On 03/29/2013 10:52 AM, Allen Martin wrote:
On Fri, Mar 29, 2013 at 10:49:06AM -0700, York Sun wrote:
On 03/29/2013 10:29 AM, Allen Martin wrote:
On Fri, Mar 29, 2013 at 09:56:41AM -0700, York Sun wrote:
On 03/27/2013 12:55 PM, Tom Rini wrote: > On Thu, Mar 21, 2013 at 01:38:37PM -0700, York Sun wrote: >> On 03/21/2013 01:28 PM, Allen Martin wrote: > [snip] >>> PS: What happened with your bool fixup patch? I'm a big fan of
that
>>> patch :^) >>> >> >> Tom asked on March 4th. I think he will accept it. > > I never got the expected acks on v7 that I thought would be
forthcoming.
>
Allen,
Can you ack the v7 of the bool fixup patch? Tom seems waiting for
you.
Oh sorry, I didn't realize there was a newer version of the patch I hadn't ack'ed yet. I'll take a look today. Do you know if it still applies cleanly to TOT u-boot/master, or will it need to be rebased?
It almost applies cleanly.
Checking patch board/xilinx/common/xbasic_types.h... error: board/xilinx/common/xbasic_types.h: does not exist in index
due to commit
commit 151eeeb2754da4b2d26bb878206d45ce58276fe0 Author: Michal Simek michal.simek@xilinx.com Date: Wed Jan 23 14:11:50 2013 +0100
board: xilinx: Remove common folder All these files was used for ancient xilinx drivers which are finally gone. Signed-off-by: Michal Simek <michal.simek@xilinx.com> Tested-by: Rommel Custodio <sessyargc@gmail.com>board/xilinx/common/xbasic_types.c | 165 ---- board/xilinx/common/xbasic_types.h | 283 ------ board/xilinx/common/xbuf_descriptor.h | 252 ------ board/xilinx/common/xdma_channel.c | 738 ---------------- board/xilinx/common/xdma_channel.h | 291 ------ board/xilinx/common/xdma_channel_i.h | 110 --- board/xilinx/common/xdma_channel_sg.c | 1317
board/xilinx/common/xio.h | 81 -- board/xilinx/common/xipif_v1_23_b.c | 331 ------- board/xilinx/common/xipif_v1_23_b.h | 746 ---------------- board/xilinx/common/xpacket_fifo_v1_00_b.c | 448 ---------- board/xilinx/common/xpacket_fifo_v1_00_b.h | 306 ------- board/xilinx/common/xstatus.h | 347 -------- board/xilinx/common/xversion.c | 350 -------- board/xilinx/common/xversion.h | 97 -- board/xilinx/zynq/Makefile | 3 - 16 files changed, 5865 deletions(-)
Do I need to send a newer version?
Tom will probably make you send a newer one anyway. I'll fix it up locally and start testing in the mean time.
Allen,
I didn't change anything for the version, only removed "RFC" from the subject. I have been there for quite a while. I thought Tom was going to pick it up.
Yeah sorry, I would have re-acked it if I saw there was a new version. Since it no longer applies cleanly I'm pretty sure he'll ask you to send a new version that does even if there are no other differences.
Maybe we can talk Simon Glass into testing it out with his super fast multi-arch u-boot builder. It's way fancier than the perl script I use. Adding Simon.
The patch in question is: http://patchwork.ozlabs.org/patch/217088/
Yes, it needs a rebase, but the change is minor - I hope we can get this in. York can you do a rebase?
Here are the boards that seem to fail: EVB64260 ZUMA EVB64260_750CX P3G4
Full output:
02: Consolidate bool type powerpc: + EVB64260 ZUMA EVB64260_750CX P3G4 +In file included from memory.c:9:0: +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:62:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:63:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:66:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:70:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:77:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:82:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:83:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:84:1: error: unknown type name 'bool' +memory.c:175:1: error: unknown type name 'bool' +memory.c: In function 'memoryMapBank': +memory.c:199:12: error: 'true' undeclared (first use in this function) +memory.c:199:12: note: each undeclared identifier is reported only once for each function it appears in +memory.c: At top level: +memory.c:201:1: error: unknown type name 'bool' +memory.c: In function 'memoryMapDeviceSpace': +memory.c:219:12: error: 'true' undeclared (first use in this function) +memory.c:230:1: error: unknown type name 'bool' +memory.c: In function 'memoryMapInternalRegistersSpace': +memory.c:240:12: error: 'true' undeclared (first use in this function) +memory.c:267:1: error: unknown type name 'bool' +memory.c: In function 'memorySetProtectRegion': +memory.c:280:9: error: 'true' undeclared (first use in this function) +memory.c:306:1: error: unknown type name 'bool' +memory.c: In function 'memorySetRegionSnoopMode': +memory.c:317:9: error: 'false' undeclared (first use in this function) +memory.c:324:9: error: 'true' undeclared (first use in this function) +memory.c:342:1: error: unknown type name 'bool' +memory.c: In function 'memoryRemapAddress': +memory.c:347:12: error: 'true' undeclared (first use in this function) +memory.c:360:1: error: unknown type name 'bool' +memory.c: In function 'memoryGetDeviceParam': +memory.c:403:12: error: 'true' undeclared (first use in this function) +memory.c:416:1: error: unknown type name 'bool' +memory.c: In function 'memorySetDeviceParam': +memory.c:423:9: error: 'false' undeclared (first use in this function) +memory.c:456:12: error: 'true' undeclared (first use in this function) +memory.c:457:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:404:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:348:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:332:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:289:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:241:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:220:1: warning: control reaches end of non-void function [-Wreturn-type] +memory.c:200:1: warning: control reaches end of non-void function [-Wreturn-type] +make[1]: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/build/board/evb64260/memory.o] Error 1 +make: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/build/board/evb64260/libevb64260.o] Error 2 +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:62:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:63:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:66:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:70:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:77:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:82:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:83:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/include/galileo/memory.h:84:1: error: unknown type name 'bool' +make[1]: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/build/board/evb64260/memory.o] Error 1 +make: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/08/build/board/evb64260/libevb64260.o] Error 2 +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:62:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:63:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:66:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:70:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:77:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:82:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:83:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/include/galileo/memory.h:84:1: error: unknown type name 'bool' +make[1]: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/build/board/evb64260/memory.o] Error 1 +make: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/16/build/board/evb64260/libevb64260.o] Error 2 +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:62:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:63:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:66:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:70:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:77:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:82:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:83:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/include/galileo/memory.h:84:1: error: unknown type name 'bool' +make[1]: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/build/board/evb64260/memory.o] Error 1 +make: *** [/c/cosarm/src/third_party/u-boot/try-york/.bm-work/07/build/board/evb64260/libevb64260.o] Error 2
Regards Simon
On 03/30/2013 03:30 PM, Simon Glass wrote:
+U-Boot
Hi Allen, York,
On Fri, Mar 29, 2013 at 11:05 AM, Allen Martin <amartin@nvidia.com mailto:amartin@nvidia.com> wrote:
On Fri, Mar 29, 2013 at 10:56:33AM -0700, York Sun wrote: > On 03/29/2013 10:52 AM, Allen Martin wrote: > > On Fri, Mar 29, 2013 at 10:49:06AM -0700, York Sun wrote: > >> On 03/29/2013 10:29 AM, Allen Martin wrote: > >>> On Fri, Mar 29, 2013 at 09:56:41AM -0700, York Sun wrote: > >>>> On 03/27/2013 12:55 PM, Tom Rini wrote: > >>>>> On Thu, Mar 21, 2013 at 01:38:37PM -0700, York Sun wrote: > >>>>>> On 03/21/2013 01:28 PM, Allen Martin wrote: > >>>>> [snip] > >>>>>>> PS: What happened with your bool fixup patch? I'm a big fan of that > >>>>>>> patch :^) > >>>>>>> > >>>>>> > >>>>>> Tom asked on March 4th. I think he will accept it. > >>>>> > >>>>> I never got the expected acks on v7 that I thought would be forthcoming. > >>>>> > >>>> > >>>> Allen, > >>>> > >>>> Can you ack the v7 of the bool fixup patch? Tom seems waiting for you. > >>> > >>> Oh sorry, I didn't realize there was a newer version of the patch I > >>> hadn't ack'ed yet. I'll take a look today. Do you know if it still > >>> applies cleanly to TOT u-boot/master, or will it need to be rebased? > >>> > >> > >> It almost applies cleanly. > >> > >> Checking patch board/xilinx/common/xbasic_types.h... > >> error: board/xilinx/common/xbasic_types.h: does not exist in index > >> > >> due to commit > >> > >> commit 151eeeb2754da4b2d26bb878206d45ce58276fe0 > >> Author: Michal Simek <michal.simek@xilinx.com <mailto:michal.simek@xilinx.com>> > >> Date: Wed Jan 23 14:11:50 2013 +0100 > >> > >> board: xilinx: Remove common folder > >> > >> All these files was used for ancient xilinx drivers > >> which are finally gone. > >> > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com <mailto:michal.simek@xilinx.com>> > >> Tested-by: Rommel Custodio <sessyargc@gmail.com <mailto:sessyargc@gmail.com>> > >> > >> board/xilinx/common/xbasic_types.c | 165 ---- > >> board/xilinx/common/xbasic_types.h | 283 ------ > >> board/xilinx/common/xbuf_descriptor.h | 252 ------ > >> board/xilinx/common/xdma_channel.c | 738 ---------------- > >> board/xilinx/common/xdma_channel.h | 291 ------ > >> board/xilinx/common/xdma_channel_i.h | 110 --- > >> board/xilinx/common/xdma_channel_sg.c | 1317 > >> ---------------------------- > >> board/xilinx/common/xio.h | 81 -- > >> board/xilinx/common/xipif_v1_23_b.c | 331 ------- > >> board/xilinx/common/xipif_v1_23_b.h | 746 ---------------- > >> board/xilinx/common/xpacket_fifo_v1_00_b.c | 448 ---------- > >> board/xilinx/common/xpacket_fifo_v1_00_b.h | 306 ------- > >> board/xilinx/common/xstatus.h | 347 -------- > >> board/xilinx/common/xversion.c | 350 -------- > >> board/xilinx/common/xversion.h | 97 -- > >> board/xilinx/zynq/Makefile | 3 - > >> 16 files changed, 5865 deletions(-) > >> > >> > >> Do I need to send a newer version? > >> > > > > Tom will probably make you send a newer one anyway. I'll fix it up > > locally and start testing in the mean time. > > > > Allen, > > I didn't change anything for the version, only removed "RFC" from the > subject. I have been there for quite a while. I thought Tom was going to > pick it up. Yeah sorry, I would have re-acked it if I saw there was a new version. Since it no longer applies cleanly I'm pretty sure he'll ask you to send a new version that does even if there are no other differences. Maybe we can talk Simon Glass into testing it out with his super fast multi-arch u-boot builder. It's way fancier than the perl script I use. Adding Simon. The patch in question is: http://patchwork.ozlabs.org/patch/217088/Yes, it needs a rebase, but the change is minor - I hope we can get this in. York can you do a rebase?
Here are the boards that seem to fail: EVB64260 ZUMA EVB64260_750CX P3G4
Thanks, Simon. I will rebase the patch and address those failure.
York
participants (2)
-
Simon Glass -
York Sun