[U-Boot] [PATCH 0/3] cm-t54: misc board fixes, convert to generic board
Fix MAC address data read (from EEPROM) issue and boot mode check. Convert to generic board.
Dmitry Lifshitz (3): cm-t54: fix EEPROM read return value check cm-t54: fix eMMC boot mode check cm-t54: convert to generic board
board/compulab/cm_t54/cm_t54.c | 6 +++--- include/configs/cm_t54.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-)
Fix cl_eeprom_read_mac_addr() return value check. Fix long line codding style issue in board_init().
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- board/compulab/cm_t54/cm_t54.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/compulab/cm_t54/cm_t54.c b/board/compulab/cm_t54/cm_t54.c index fadfddc..306491b 100644 --- a/board/compulab/cm_t54/cm_t54.c +++ b/board/compulab/cm_t54/cm_t54.c @@ -43,7 +43,7 @@ const struct omap_sysinfo sysinfo = { */ int board_init(void) { - gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100); /* boot param addr */ + gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100);
return 0; } @@ -169,7 +169,7 @@ static int handle_mac_address(void) return 0;
ret = cl_eeprom_read_mac_addr(enetaddr); - if (!ret || !is_valid_ether_addr(enetaddr)) + if (ret || !is_valid_ether_addr(enetaddr)) generate_mac_addr(enetaddr);
if (!is_valid_ether_addr(enetaddr))
On Thu, Jul 31, 2014 at 02:30:39PM +0300, Dmitry Lifshitz wrote:
Fix cl_eeprom_read_mac_addr() return value check. Fix long line codding style issue in board_init().
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Applied to u-boot-ti/master, thanks!
Boot from eMMC boot partition corresponds to BOOT_DEVICE_MMC2 omap_bootmode, while BOOT_DEVICE_MMC2_2 corresponds to the user data partition boot.
Fix mmc_get_env_part() boot mode check to use a correct value.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- board/compulab/cm_t54/cm_t54.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/compulab/cm_t54/cm_t54.c b/board/compulab/cm_t54/cm_t54.c index 306491b..944b723 100644 --- a/board/compulab/cm_t54/cm_t54.c +++ b/board/compulab/cm_t54/cm_t54.c @@ -89,7 +89,7 @@ uint mmc_get_env_part(struct mmc *mmc) * If booted from eMMC boot partition then force eMMC * FIRST boot partition to be env storage */ - if (bootmode == BOOT_DEVICE_MMC2_2) + if (bootmode == BOOT_DEVICE_MMC2) bootpart = 1;
return bootpart;
On Thu, Jul 31, 2014 at 02:30:40PM +0300, Dmitry Lifshitz wrote:
Boot from eMMC boot partition corresponds to BOOT_DEVICE_MMC2 omap_bootmode, while BOOT_DEVICE_MMC2_2 corresponds to the user data partition boot.
Fix mmc_get_env_part() boot mode check to use a correct value.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Applied to u-boot-ti/master, thanks!
Use generic board setup functions by defining CONFIG_SYS_GENERIC_BOARD.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- include/configs/cm_t54.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/cm_t54.h b/include/configs/cm_t54.h index db04095..df93a59 100644 --- a/include/configs/cm_t54.h +++ b/include/configs/cm_t54.h @@ -19,6 +19,9 @@ #undef CONFIG_MISC_INIT_R #undef CONFIG_SPL_OS_BOOT
+/* Enable Generic board */ +#define CONFIG_SYS_GENERIC_BOARD + /* Device Tree defines */ #define CONFIG_OF_LIBFDT #define CONFIG_OF_BOARD_SETUP
On Thu, Jul 31, 2014 at 02:30:41PM +0300, Dmitry Lifshitz wrote:
Use generic board setup functions by defining CONFIG_SYS_GENERIC_BOARD.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Applied to u-boot-ti/master, thanks!
Gentle ping...
On 07/31/14 14:30, Dmitry Lifshitz wrote:
Fix MAC address data read (from EEPROM) issue and boot mode check. Convert to generic board.
Dmitry Lifshitz (3): cm-t54: fix EEPROM read return value check cm-t54: fix eMMC boot mode check cm-t54: convert to generic board
board/compulab/cm_t54/cm_t54.c | 6 +++--- include/configs/cm_t54.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-)
participants (3)
-
Dmitry Lifshitz -
Igor Grinberg -
Tom Rini