[U-Boot] [PATCH v2] net: Kconfig: select PHY_GIGE for SUN8I_EMAC

newer
Re: [U-Boot] [PATCH v2 2/2] board:...

Philipp Tomsich

22 Feb 2017 22 Feb '17

9:58 p.m.

This now moves the PHY_GIGE, PHY_MICREL_KSZ9021 and PHY_MICREL_KSZ9031 into Kconfig, so we can select them from our defconfig.

For SUN8I, we select PHY_GIGE automatically.

Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

Philipp Tomsich (1): net: Kconfig:make PHY_GIGE and individual Micrel PHYs selectable

drivers/net/Kconfig | 7 +++++++ drivers/net/phy/Kconfig | 10 ++++++++++ 2 files changed, 17 insertions(+)

-- 1.9.1

Show replies by date

Philipp Tomsich

22 Feb 22 Feb

9:58 p.m.

This now moves the PHY_GIGE, PHY_MICREL_KSZ9021 and PHY_MICREL_KSZ9031 into Kconfig, so we can select them from our defconfig.

For SUN8I, we select PHY_GIGE automatically. The same goes for SUNXI_GMAC.

Philipp Tomsich (1): net: Kconfig:make PHY_GIGE and individual Micrel PHYs selectable

drivers/net/Kconfig | 7 +++++++ drivers/net/phy/Kconfig | 10 ++++++++++ 2 files changed, 17 insertions(+)

-- 1.9.1

Philipp Tomsich

9:58 p.m.

New subject: [U-Boot] [PATCH v2] net: Kconfig:make PHY_GIGE and individual Micrel PHYs selectable

This changeset moves two configuration options into Kconfig: * PHY_GIGE, indicates that a controller (with an appropriate PHY) is Gigabit capable and enables extra support in the miiutil for parsing the status of Gigabit PHYs * individual configuration options for MICREL_KSZ9021 and MICREL_KSZ9031 GbE PHYs, which previously had to enabled through a board-specific config file

Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com --- drivers/net/Kconfig | 7 +++++++ drivers/net/phy/Kconfig | 10 ++++++++++ 2 files changed, 17 insertions(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 078d5a8..845df09 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -22,6 +22,12 @@ menuconfig NETDEVICES

if NETDEVICES

+config PHY_GIGE + bool + help + Enables support for parsing the status output and + configuring GbE PHYs (e.g. via miiphyutil.c) + config AG7XXX bool "Atheros AG7xxx Ethernet MAC support" depends on DM_ETH && ARCH_ATH79 @@ -165,6 +171,7 @@ config SUN8I_EMAC bool "Allwinner Sun8i Ethernet MAC support" depends on DM_ETH select PHYLIB + select PHY_GIGE help This driver supports the Allwinner based SUN8I/SUN50I Ethernet MAC. It can be found in H3/A64/A83T based SoCs and compatible with both diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 1d514e9..0941383 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -45,6 +45,16 @@ config PHY_MARVELL config PHY_MICREL bool "Micrel Ethernet PHYs support"

+if PHY_MICREL + +config PHY_MICREL_KSZ9021 + bool "Micrel KSZ9021 family support" + +config PHY_MICREL_KSZ9031 + bool "Micrel KSZ9031 family support" + +endif # PHY_MICREL + config PHY_MSCC bool "Microsemi Corp Ethernet PHYs support"

-- 1.9.1

Maxime Ripard

23 Feb 23 Feb

12:55 a.m.

New subject: [U-Boot] [PATCH v2] net: Kconfig:make PHY_GIGE and individual Micrel PHYs selectable

Hi,

On Wed, Feb 22, 2017 at 09:58:42PM +0100, Philipp Tomsich wrote:

...

This changeset moves two configuration options into Kconfig:

PHY_GIGE, indicates that a controller (with an appropriate PHY) is Gigabit capable and enables extra support in the miiutil for parsing the status of Gigabit PHYs

individual configuration options for MICREL_KSZ9021 and MICREL_KSZ9031 GbE PHYs, which previously had to enabled through a board-specific config file

Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

drivers/net/Kconfig | 7 +++++++ drivers/net/phy/Kconfig | 10 ++++++++++ 2 files changed, 17 insertions(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 078d5a8..845df09 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -22,6 +22,12 @@ menuconfig NETDEVICES

if NETDEVICES

+config PHY_GIGE
   bool

The indentation is wrong here (spaces instead of tabs), and it would be great if you could add a label, so that we can select in in menuconfig.

...

help
 Enables support for parsing the status output and
 configuring GbE PHYs (e.g. via miiphyutil.c)
config AG7XXX bool "Atheros AG7xxx Ethernet MAC support" depends on DM_ETH && ARCH_ATH79 @@ -165,6 +171,7 @@ config SUN8I_EMAC bool "Allwinner Sun8i Ethernet MAC support" depends on DM_ETH select PHYLIB

select PHY_GIGE help This driver supports the Allwinner based SUN8I/SUN50I Ethernet MAC. It can be found in H3/A64/A83T based SoCs and compatible with both

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 1d514e9..0941383 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -45,6 +45,16 @@ config PHY_MARVELL config PHY_MICREL bool "Micrel Ethernet PHYs support"

+if PHY_MICREL

+config PHY_MICREL_KSZ9021
   bool "Micrel KSZ9021 family support"
+config PHY_MICREL_KSZ9031
   bool "Micrel KSZ9031 family support"

There's the same indentation issues here, and having some help notice would be great.

Thanks! Maxime

-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Joe Hershberger

26 Mar 26 Mar

3:52 p.m.

New subject: [U-Boot] [PATCH v2] net: Kconfig:make PHY_GIGE and individual Micrel PHYs selectable

On Wed, Feb 22, 2017 at 6:55 PM, Maxime Ripard maxime.ripard@free-electrons.com wrote:

...

Hi,

On Wed, Feb 22, 2017 at 09:58:42PM +0100, Philipp Tomsich wrote:

...
This changeset moves two configuration options into Kconfig:

PHY_GIGE, indicates that a controller (with an appropriate PHY) is Gigabit capable and enables extra support in the miiutil for parsing the status of Gigabit PHYs

individual configuration options for MICREL_KSZ9021 and MICREL_KSZ9031 GbE PHYs, which previously had to enabled through a board-specific config file

Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

drivers/net/Kconfig | 7 +++++++ drivers/net/phy/Kconfig | 10 ++++++++++ 2 files changed, 17 insertions(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 078d5a8..845df09 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -22,6 +22,12 @@ menuconfig NETDEVICES

if NETDEVICES

+config PHY_GIGE
   bool
The indentation is wrong here (spaces instead of tabs), and it would be great if you could add a label, so that we can select in in menuconfig.

Agreed... please fix and send v3.

...

...
help
  Enables support for parsing the status output and
  configuring GbE PHYs (e.g. via miiphyutil.c)
config AG7XXX bool "Atheros AG7xxx Ethernet MAC support" depends on DM_ETH && ARCH_ATH79 @@ -165,6 +171,7 @@ config SUN8I_EMAC bool "Allwinner Sun8i Ethernet MAC support" depends on DM_ETH select PHYLIB
select PHY_GIGE
   help
     This driver supports the  Allwinner based SUN8I/SUN50I Ethernet MAC.
  It can be found in H3/A64/A83T based SoCs and compatible with both
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 1d514e9..0941383 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -45,6 +45,16 @@ config PHY_MARVELL config PHY_MICREL bool "Micrel Ethernet PHYs support"

+if PHY_MICREL

+config PHY_MICREL_KSZ9021
   bool "Micrel KSZ9021 family support"
+config PHY_MICREL_KSZ9031
   bool "Micrel KSZ9031 family support"
There's the same indentation issues here, and having some help notice would be great.

Thanks! Maxime

-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

2963

Age (days ago)

2995

Last active (days ago)

List overview

Download

4 comments

3 participants

tags (0)

participants (3)

Joe Hershberger
Maxime Ripard
Philipp Tomsich