[U-Boot] [PATCH] tools: fix Makefile to clean-up fit_info and fit_check_sign
We should avoid the description in Makefile like this
ifdef CONFIG_FIT_SIGNATURE hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) endif
Otherwise, fit_info and fit_check_sign would never be cleaned by "make clean".
Cc: Heiko Schocher hs@denx.de --- tools/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index c5c378c..c34df4f 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,9 +60,7 @@ hostprogs-y += mkenvimage$(SFX) mkenvimage$(SFX)-objs := crc32.o mkenvimage.o os_support.o
hostprogs-y += dumpimage$(SFX) mkimage$(SFX) -ifdef CONFIG_FIT_SIGNATURE -hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) -endif +hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info$(SFX) fit_check_sign$(SFX)
FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig.o # Flattened device tree objects
On Fri, Mar 28, 2014 at 03:09:51PM +0900, Masahiro Yamada wrote:
We should avoid the description in Makefile like this
ifdef CONFIG_FIT_SIGNATURE hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) endif
Otherwise, fit_info and fit_check_sign would never be cleaned by "make clean".
Cc: Heiko Schocher hs@denx.de
tools/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index c5c378c..c34df4f 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,9 +60,7 @@ hostprogs-y += mkenvimage$(SFX) mkenvimage$(SFX)-objs := crc32.o mkenvimage.o os_support.o
hostprogs-y += dumpimage$(SFX) mkimage$(SFX) -ifdef CONFIG_FIT_SIGNATURE -hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) -endif +hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info$(SFX) fit_check_sign$(SFX)
FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig.o # Flattened device tree objects
What tree is this against, exactly?
Hi Tom,
On Fri, 28 Mar 2014 15:12:25 -0400 Tom Rini trini@ti.com wrote:
On Fri, Mar 28, 2014 at 03:09:51PM +0900, Masahiro Yamada wrote:
We should avoid the description in Makefile like this
ifdef CONFIG_FIT_SIGNATURE hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) endif
Otherwise, fit_info and fit_check_sign would never be cleaned by "make clean".
Cc: Heiko Schocher hs@denx.de
tools/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index c5c378c..c34df4f 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,9 +60,7 @@ hostprogs-y += mkenvimage$(SFX) mkenvimage$(SFX)-objs := crc32.o mkenvimage.o os_support.o
hostprogs-y += dumpimage$(SFX) mkimage$(SFX) -ifdef CONFIG_FIT_SIGNATURE -hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) -endif +hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info$(SFX) fit_check_sign$(SFX)
FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig.o # Flattened device tree objects
What tree is this against, exactly?
It's against u-boot/next because commit 6bf4ca076 and commit 29a23f9d went there.
I forgot to add Signed-off-by. If you need it, I will resend it.
Best Regards Masahiro Yamada
On Mon, Mar 31, 2014 at 10:58:33AM +0900, Masahiro Yamada wrote:
Hi Tom,
On Fri, 28 Mar 2014 15:12:25 -0400 Tom Rini trini@ti.com wrote:
On Fri, Mar 28, 2014 at 03:09:51PM +0900, Masahiro Yamada wrote:
We should avoid the description in Makefile like this
ifdef CONFIG_FIT_SIGNATURE hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) endif
Otherwise, fit_info and fit_check_sign would never be cleaned by "make clean".
Cc: Heiko Schocher hs@denx.de
tools/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index c5c378c..c34df4f 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,9 +60,7 @@ hostprogs-y += mkenvimage$(SFX) mkenvimage$(SFX)-objs := crc32.o mkenvimage.o os_support.o
hostprogs-y += dumpimage$(SFX) mkimage$(SFX) -ifdef CONFIG_FIT_SIGNATURE -hostprogs-y += fit_info$(SFX) fit_check_sign$(SFX) -endif +hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info$(SFX) fit_check_sign$(SFX)
FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig.o # Flattened device tree objects
What tree is this against, exactly?
It's against u-boot/next because commit 6bf4ca076 and commit 29a23f9d went there.
I forgot to add Signed-off-by. If you need it, I will resend it.
Ah, OK. Yeah, please do. Thanks!
participants (2)
-
Masahiro Yamada -
Tom Rini