[U-Boot-Users] [PATCH] include top config.mk only after CROSS_COMPILE is defined

Hi Wolfgang!
During compiling I just spotted the fact that gccincdir := $(shell $(CC) -print-file-name=include) in the top config.mk does execute "gcc -print-file-name=include" instead of "m68k-elf-gcc ..." which I would expect as i compile for m68k. I think that this does not make much difference as the includes should mostly be the same, but for the sake of completeness I want to bring the attached patch to your attention.
Description of the patch:
* CROSS_COMPILE is referenced in the top 'config.mk' file therefore we need to include it in the main Makefile only after CROSS_COMPILE is defined
This patch is against the u-boot-1.1.2.

Friedrich Lobenstock wrote on 02.06.2005 01:17 MET:
Description of the patch:
- CROSS_COMPILE is referenced in the top 'config.mk' file therefore we need to include it in the main Makefile only after CROSS_COMPILE is defined
This patch is against the u-boot-1.1.2.
Just checked, patch also applies cleanly to u-boot cvs head.

Friedrich Lobenstock wrote:
Hi Wolfgang!
During compiling I just spotted the fact that gccincdir := $(shell $(CC) -print-file-name=include) in the top config.mk does execute "gcc -print-file-name=include" instead of "m68k-elf-gcc ..." which I would expect as i compile for m68k. I think that this does not make much difference as the includes should mostly be the same, but for the sake of completeness I want to bring the attached patch to your attention.
Bump & resubmit...
This particular issue broke cross-compilation for all of our ARM-based projects following a repository sync yesterday.
The attached patch was generated against a 2005.11.29 CVS pull.
CHANGELOG: * Patch by Cory Tusar, 30 Nov 2005: * Original patch by Friedrich Lobenstock, 01 Jun 2005: CROSS_COMPILE is referenced in the top 'config.mk' file, therefore we need to include it in the main Makefile only after CROSS_COMPILE has been defined.
-Cory

In message 429E4223.5090009@scottygroup.com you wrote:
- CROSS_COMPILE is referenced in the top 'config.mk' file therefore we need to include it in the main Makefile only after CROSS_COMPILE is defined
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Cory T. Tusar
-
Friedrich Lobenstock
-
Wolfgang Denk