[U-Boot] why does only zynqmp check GD_FLG_ENV_DEFAULT?
another curiosity, if i might ... notice:
$ grep -r GD_FLG_ENV_DEFAULT * board/xilinx/zynqmp/zynqmp.c: if (!(gd->flags & GD_FLG_ENV_DEFAULT)) { common/env_common.c: gd->flags |= GD_FLG_ENV_DEFAULT; include/asm-generic/global_data.h:#define GD_FLG_ENV_DEFAULT 0x02000 /* Default variable flag */ $
it seems a bit odd that there is a u-boot-wide global data flag that is tested by only a single board. what exactly does that flag represent?
rday
Hi,
zynqmp is using it because we don't want to rewrite boot sequence if variables are saved already.
You should look at these patches git show 340b0e3bb6e88 git show b72894f14da79
I expect you will find out thread about it too.
Thanks, Michal
On 7.9.2016 13:00, Robert P. J. Day wrote:
another curiosity, if i might ... notice:
$ grep -r GD_FLG_ENV_DEFAULT * board/xilinx/zynqmp/zynqmp.c: if (!(gd->flags & GD_FLG_ENV_DEFAULT)) { common/env_common.c: gd->flags |= GD_FLG_ENV_DEFAULT; include/asm-generic/global_data.h:#define GD_FLG_ENV_DEFAULT 0x02000 /* Default variable flag */ $
it seems a bit odd that there is a u-boot-wide global data flag that is tested by only a single board. what exactly does that flag represent?
rday
On Wed, 7 Sep 2016, Michal Simek wrote:
Hi,
zynqmp is using it because we don't want to rewrite boot sequence if variables are saved already.
You should look at these patches git show 340b0e3bb6e88 git show b72894f14da79
I expect you will find out thread about it too.
Thanks, Michal
ah, thanks. i guess it's just odd that no one else takes advantage of that, it seems like a reasonable thing to do.
rday
participants (2)
-
Michal Simek -
Robert P. J. Day