[U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes

From: Mirza Krak mirza.krak@hostmobility.com
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
Signed-off-by: Mirza Krak mirza.krak@hostmobility.com ---
Changes in v2: * Dropped tegra30-slink compatible string, based on comment from Thierry Reding on v1 patch
arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi index b8c8a923017e..e4d7c7a83473 100644 --- a/arch/arm/dts/tegra20.dtsi +++ b/arch/arm/dts/tegra20.dtsi @@ -268,6 +268,50 @@ #pwm-cells = <2>; };
+ spi@7000d400 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d400 0x200>; + interrupts = <0 59 0x04>; + nvidia,dma-request-selector = <&apbdma 15>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 41>; + status = "disabled"; + }; + + spi@7000d600 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d600 0x200>; + interrupts = <0 82 0x04>; + nvidia,dma-request-selector = <&apbdma 16>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 44>; + status = "disabled"; + }; + + spi@7000d800 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d480 0x200>; + interrupts = <0 83 0x04>; + nvidia,dma-request-selector = <&apbdma 17>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 46>; + status = "disabled"; + }; + + spi@7000da00 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000da00 0x200>; + interrupts = <0 93 0x04>; + nvidia,dma-request-selector = <&apbdma 18>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 68>; + status = "disabled"; + }; + i2c@7000c000 { #address-cells = <1>; #size-cells = <0>; -- 2.1.0

On 07/21/2015 03:36 AM, Mirza Krak wrote:
From: Mirza Krak mirza.krak@hostmobility.com
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
- spi@7000d400 {
compatible = "nvidia,tegra20-slink";
reg = <0x7000d400 0x200>;
interrupts = <0 59 0x04>;
nvidia,dma-request-selector = <&apbdma 15>;
That property doesn't seem to exist in the kernel DT, and "resets", "reset-names", "dmas", "dma-names" are missing. I'd suggest simply cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named constants for better readability and the same consistency reasons.

Hi,
On 21 July 2015 at 09:56, Stephen Warren swarren@wwwdotorg.org wrote:
On 07/21/2015 03:36 AM, Mirza Krak wrote:
From: Mirza Krak mirza.krak@hostmobility.com
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
spi@7000d400 {
compatible = "nvidia,tegra20-slink";
reg = <0x7000d400 0x200>;
interrupts = <0 59 0x04>;
nvidia,dma-request-selector = <&apbdma 15>;
That property doesn't seem to exist in the kernel DT, and "resets", "reset-names", "dmas", "dma-names" are missing. I'd suggest simply cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named constants for better readability and the same consistency reasons.
Also it's pretty easy to just copy over the kernel files. They should just work!
Regards, Simon

2015-07-21 22:28 GMT+02:00 Simon Glass sjg@chromium.org:
Hi
Also it's pretty easy to just copy over the kernel files. They should just work!
Regards, Simon
Ok, will give it a go then.
participants (3)
-
Mirza Krak
-
Simon Glass
-
Stephen Warren