[U-Boot] [PATCH 1/2] mx28evk: Convert to PHYLIB
From: Fabio Estevam fabio.estevam@freescale.com
Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx28evk/mx28evk.c | 7 +++++++ include/configs/mx28evk.h | 2 ++ 2 files changed, 9 insertions(+)
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 4edd9f4..fc204fc 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -105,6 +105,13 @@ int board_mmc_init(bd_t *bis) #endif
#ifdef CONFIG_CMD_NET +int board_phy_config(struct phy_device *phydev) +{ + if (phydev->drv->config) + phydev->drv->config(phydev); + + return 0; +}
int board_eth_init(bd_t *bis) { diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index de69182..a3e2c0e 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -176,6 +176,8 @@ #define CONFIG_MII #define CONFIG_FEC_XCV_TYPE RMII #define CONFIG_MX28_FEC_MAC_IN_OCOTP +#define CONFIG_PHYLIB +#define CONFIG_PHY_SMSC #endif
/* RTC */
From: Fabio Estevam fabio.estevam@freescale.com
LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
Cc: Joe Hershberger joe.hershberger@ni.com Cc: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- drivers/net/phy/smsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 6dee8eb..0c658f4 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -76,7 +76,7 @@ static struct phy_driver lan8710_driver = { .name = "SMSC LAN8710/LAN8720", .uid = 0x0007c0f0, .mask = 0xffff0, - .features = PHY_GBIT_FEATURES, + .features = PHY_BASIC_FEATURES, .config = &genphy_config_aneg, .startup = &smsc_startup, .shutdown = &genphy_shutdown,
Hi Joe,
On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
Cc: Joe Hershberger joe.hershberger@ni.com Cc: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Any comments?
On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam festevam@gmail.com wrote:
Hi Joe,
On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
Cc: Joe Hershberger joe.hershberger@ni.com Cc: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Any comments?
Seems pretty reasonable. I'll pick it up for next release.
-Joe
On Thu, Jul 11, 2013 at 11:57 PM, Joe Hershberger joe.hershberger@gmail.com wrote:
On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam festevam@gmail.com wrote:
Hi Joe,
On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
Cc: Joe Hershberger joe.hershberger@ni.com Cc: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Any comments?
Seems pretty reasonable. I'll pick it up for next release.
On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?
-Joe
On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger joe.hershberger@gmail.com wrote:
On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?
Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).
This one (2/2) is fine.
Sorry for the confusion.
On Fri, Jul 12, 2013 at 12:06 AM, Fabio Estevam festevam@gmail.com wrote:
On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger joe.hershberger@gmail.com wrote:
On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?
Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).
This one (2/2) is fine.
Sorry for the confusion.
OK. That sounds fine.
-Joe
On 12/07/2013 07:06, Fabio Estevam wrote:
On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger joe.hershberger@gmail.com wrote:
On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?
Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).
This one (2/2) is fine.
Sorry for the confusion.
Yes, I confirm this - I rejected on Fabio's request.
Regards, Stefano
On Thu, Jun 6, 2013 at 7:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
Cc: Joe Hershberger joe.hershberger@ni.com Cc: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied, Thanks! -Joe
Hi Stefano,
On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Please discard this one for now.
I found an issue with this one.
On 07/06/2013 02:25, Fabio Estevam wrote:
Hi Stefano,
On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam festevam@gmail.com wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Please discard this one for now.
I found an issue with this one.
Ok, thanks.
Stefano
participants (3)
-
Fabio Estevam -
Joe Hershberger -
Stefano Babic