[U-Boot] [PATCH v2] f_thor: Dont perform reset at the end of thor
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Changes in v2: - Update commit message with additional description
drivers/usb/gadget/f_thor.c | 7 +++++++ drivers/usb/gadget/f_thor.h | 3 +++ 2 files changed, 10 insertions(+)
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c index e9a690eff5f1..5c8f6768519c 100644 --- a/drivers/usb/gadget/f_thor.c +++ b/drivers/usb/gadget/f_thor.c @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt) send_rsp(rsp); g_dnl_unregister(); dfu_free_entities(); +#ifdef CONFIG_THOR_RESET_OFF + return RESET_DONE; +#endif run_command("reset", 0); break; case RQT_CMD_POWEROFF: @@ -728,6 +731,10 @@ int thor_handle(void)
if (ret > 0) { ret = process_data(); +#ifdef CONFIG_THOR_RESET_OFF + if (ret == RESET_DONE) + break; +#endif if (ret < 0) return ret; } else { diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h index 833a9d24ae7e..83412851dd17 100644 --- a/drivers/usb/gadget/f_thor.h +++ b/drivers/usb/gadget/f_thor.h @@ -121,4 +121,7 @@ struct f_thor { #define F_NAME_BUF_SIZE 32 #define THOR_PACKET_SIZE SZ_1M /* 1 MiB */ #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */ +#ifdef CONFIG_THOR_RESET_OFF +#define RESET_DONE 0xFFFFFFFF +#endif #endif /* _USB_THOR_H_ */
On Thursday, April 16, 2015 at 10:38:34 AM, Michal Simek wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
And the documentation for this new config option is where exactly ? ;-)
Best regards, Marek Vasut
Hi,
On 04/16/2015 11:31 AM, Marek Vasut wrote:
On Thursday, April 16, 2015 at 10:38:34 AM, Michal Simek wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
And the documentation for this new config option is where exactly ? ;-)
ok. We will write it. It means there is no problem from your point of view about adding this feature to u-boot. It is great to know it.
Thanks, Michal
On Thursday, April 16, 2015 at 11:41:30 AM, Michal Simek wrote:
Hi,
On 04/16/2015 11:31 AM, Marek Vasut wrote:
On Thursday, April 16, 2015 at 10:38:34 AM, Michal Simek wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
And the documentation for this new config option is where exactly ? ;-)
ok. We will write it. It means there is no problem from your point of view about adding this feature to u-boot. It is great to know it.
You need ACK from Lukasz on these kinds of patches.
Best regards, Marek Vasut
Hi Lukasz,
On 04/16/2015 12:01 PM, Marek Vasut wrote:
On Thursday, April 16, 2015 at 11:41:30 AM, Michal Simek wrote:
Hi,
On 04/16/2015 11:31 AM, Marek Vasut wrote:
On Thursday, April 16, 2015 at 10:38:34 AM, Michal Simek wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
And the documentation for this new config option is where exactly ? ;-)
ok. We will write it. It means there is no problem from your point of view about adding this feature to u-boot. It is great to know it.
You need ACK from Lukasz on these kinds of patches.
Can you please give me your ACK on this one?
Thanks, Michal
Hi Michal,
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
Changes in v2:
- Update commit message with additional description
drivers/usb/gadget/f_thor.c | 7 +++++++ drivers/usb/gadget/f_thor.h | 3 +++ 2 files changed, 10 insertions(+)
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c index e9a690eff5f1..5c8f6768519c 100644 --- a/drivers/usb/gadget/f_thor.c +++ b/drivers/usb/gadget/f_thor.c @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt) send_rsp(rsp); g_dnl_unregister(); dfu_free_entities(); +#ifdef CONFIG_THOR_RESET_OFF
return RESET_DONE;+#endif run_command("reset", 0); break; case RQT_CMD_POWEROFF: @@ -728,6 +731,10 @@ int thor_handle(void)
if (ret > 0) { ret = process_data();+#ifdef CONFIG_THOR_RESET_OFF
if (ret == RESET_DONE)break;+#endif if (ret < 0) return ret; } else { diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h index 833a9d24ae7e..83412851dd17 100644 --- a/drivers/usb/gadget/f_thor.h +++ b/drivers/usb/gadget/f_thor.h @@ -121,4 +121,7 @@ struct f_thor { #define F_NAME_BUF_SIZE 32 #define THOR_PACKET_SIZE SZ_1M /* 1 MiB */ #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */ +#ifdef CONFIG_THOR_RESET_OFF +#define RESET_DONE 0xFFFFFFFF +#endif #endif /* _USB_THOR_H_ */
Applied to u-boot-dfu. Thanks
Hi Lukasz,
On 04/24/2015 05:48 PM, Lukasz Majewski wrote:
Hi Michal,
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
Changes in v2:
- Update commit message with additional description
drivers/usb/gadget/f_thor.c | 7 +++++++ drivers/usb/gadget/f_thor.h | 3 +++ 2 files changed, 10 insertions(+)
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c index e9a690eff5f1..5c8f6768519c 100644 --- a/drivers/usb/gadget/f_thor.c +++ b/drivers/usb/gadget/f_thor.c @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt) send_rsp(rsp); g_dnl_unregister(); dfu_free_entities(); +#ifdef CONFIG_THOR_RESET_OFF
return RESET_DONE;+#endif run_command("reset", 0); break; case RQT_CMD_POWEROFF: @@ -728,6 +731,10 @@ int thor_handle(void)
if (ret > 0) { ret = process_data();+#ifdef CONFIG_THOR_RESET_OFF
if (ret == RESET_DONE)break;+#endif if (ret < 0) return ret; } else { diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h index 833a9d24ae7e..83412851dd17 100644 --- a/drivers/usb/gadget/f_thor.h +++ b/drivers/usb/gadget/f_thor.h @@ -121,4 +121,7 @@ struct f_thor { #define F_NAME_BUF_SIZE 32 #define THOR_PACKET_SIZE SZ_1M /* 1 MiB */ #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */ +#ifdef CONFIG_THOR_RESET_OFF +#define RESET_DONE 0xFFFFFFFF +#endif #endif /* _USB_THOR_H_ */
Applied to u-boot-dfu. Thanks
Did you applied this patch? And also "usb: gadget: f_thor: Allocate request up to THOR_PACKET_SIZE"
I can't see that patches in you DFU tree.
Thanks, Michal
Hi Lukasz,
On 07/27/2015 12:43 PM, Michal Simek wrote:
Hi Lukasz,
On 04/24/2015 05:48 PM, Lukasz Majewski wrote:
Hi Michal,
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
Dont perform reset at the end of thor download if configured to do reset off. Reset may not be required in all cases and hence provided an option to do so.
The case would be to download the images to DDR instead of flash device.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
Changes in v2:
- Update commit message with additional description
drivers/usb/gadget/f_thor.c | 7 +++++++ drivers/usb/gadget/f_thor.h | 3 +++ 2 files changed, 10 insertions(+)
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c index e9a690eff5f1..5c8f6768519c 100644 --- a/drivers/usb/gadget/f_thor.c +++ b/drivers/usb/gadget/f_thor.c @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt) send_rsp(rsp); g_dnl_unregister(); dfu_free_entities(); +#ifdef CONFIG_THOR_RESET_OFF
return RESET_DONE;+#endif run_command("reset", 0); break; case RQT_CMD_POWEROFF: @@ -728,6 +731,10 @@ int thor_handle(void)
if (ret > 0) { ret = process_data();+#ifdef CONFIG_THOR_RESET_OFF
if (ret == RESET_DONE)break;+#endif if (ret < 0) return ret; } else { diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h index 833a9d24ae7e..83412851dd17 100644 --- a/drivers/usb/gadget/f_thor.h +++ b/drivers/usb/gadget/f_thor.h @@ -121,4 +121,7 @@ struct f_thor { #define F_NAME_BUF_SIZE 32 #define THOR_PACKET_SIZE SZ_1M /* 1 MiB */ #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */ +#ifdef CONFIG_THOR_RESET_OFF +#define RESET_DONE 0xFFFFFFFF +#endif #endif /* _USB_THOR_H_ */
Applied to u-boot-dfu. Thanks
Did you applied this patch? And also "usb: gadget: f_thor: Allocate request up to THOR_PACKET_SIZE"
I can't see that patches in you DFU tree.
Any update on this one?
Thanks, Michal
participants (4)
-
Lukasz Majewski -
Marek Vasut -
Michal Simek -
Michal Simek