[U-Boot] [PATCH v2] imx: sys_proto: Add a prototype for board_mmc_get_env_dev()
When compiling with W=1 the following warning is observed:
board/freescale/mx6sabresd/mx6sabresd.c:266:5: warning: no previous prototype for ‘board_mmc_get_env_dev’ [-Wmissing-prototypes] int board_mmc_get_env_dev(int devno)
Remove this warning by adding the function prototype into sys_proto.h file.
Signed-off-by: Diego Dorta diego.dorta@nxp.com --- Changes since v1: - Add 'mmc' prefix - Change function prototype to sys_proto.h - Update commit log accordingly
arch/arm/include/asm/mach-imx/sys_proto.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h index 970c4ca..7036343 100644 --- a/arch/arm/include/asm/mach-imx/sys_proto.h +++ b/arch/arm/include/asm/mach-imx/sys_proto.h @@ -107,6 +107,8 @@ void init_aips(void); void init_src(void); void imx_set_wdog_powerdown(bool enable);
+int board_mmc_get_env_dev(int devno); + /* * Initializes on-chip ethernet controllers. * to override, implement board_eth_init()
Hi Diego,
On Thu, Sep 21, 2017 at 3:10 PM, Diego Dorta diego.dorta@nxp.com wrote:
When compiling with W=1 the following warning is observed:
board/freescale/mx6sabresd/mx6sabresd.c:266:5: warning: no previous prototype for ‘board_mmc_get_env_dev’ [-Wmissing-prototypes] int board_mmc_get_env_dev(int devno)
Remove this warning by adding the function prototype into sys_proto.h file.
Signed-off-by: Diego Dorta diego.dorta@nxp.com
This looks better, thanks.
Reviewed-by: Fabio Estevam fabio.estevam@nxp.com
Changes since v1:
- Add 'mmc' prefix
Actually there is no mmc prefix ;-)
Hi Diego,
On 21/09/2017 20:10, Diego Dorta wrote:
When compiling with W=1 the following warning is observed:
board/freescale/mx6sabresd/mx6sabresd.c:266:5: warning: no previous prototype for ‘board_mmc_get_env_dev’ [-Wmissing-prototypes] int board_mmc_get_env_dev(int devno)
Remove this warning by adding the function prototype into sys_proto.h file.
Signed-off-by: Diego Dorta diego.dorta@nxp.com
Changes since v1:
- Add 'mmc' prefix
- Change function prototype to sys_proto.h
- Update commit log accordingly
arch/arm/include/asm/mach-imx/sys_proto.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h index 970c4ca..7036343 100644 --- a/arch/arm/include/asm/mach-imx/sys_proto.h +++ b/arch/arm/include/asm/mach-imx/sys_proto.h @@ -107,6 +107,8 @@ void init_aips(void); void init_src(void); void imx_set_wdog_powerdown(bool enable);
+int board_mmc_get_env_dev(int devno);
/*
- Initializes on-chip ethernet controllers.
- to override, implement board_eth_init()
Reviewed-by: Stefano Babic sbabic@denx.de
Best regards, Stefano Babic
On 21/09/2017 20:10, Diego Dorta wrote:
When compiling with W=1 the following warning is observed:
board/freescale/mx6sabresd/mx6sabresd.c:266:5: warning: no previous prototype for ‘board_mmc_get_env_dev’ [-Wmissing-prototypes] int board_mmc_get_env_dev(int devno)
Remove this warning by adding the function prototype into sys_proto.h file.
Signed-off-by: Diego Dorta diego.dorta@nxp.com
Changes since v1:
- Add 'mmc' prefix
- Change function prototype to sys_proto.h
- Update commit log accordingly
arch/arm/include/asm/mach-imx/sys_proto.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h index 970c4ca..7036343 100644 --- a/arch/arm/include/asm/mach-imx/sys_proto.h +++ b/arch/arm/include/asm/mach-imx/sys_proto.h @@ -107,6 +107,8 @@ void init_aips(void); void init_src(void); void imx_set_wdog_powerdown(bool enable);
+int board_mmc_get_env_dev(int devno);
/*
- Initializes on-chip ethernet controllers.
- to override, implement board_eth_init()
Applied to u-boot-imx, -master, thanks !
Best regards, Stefano Babic
participants (3)
-
Diego Dorta -
Fabio Estevam -
Stefano Babic