[U-Boot-Users] IDE Little Endian patch

The attached patch fixes IDE problems for little endian systems. The previous patch was rejected (a couple of months ago) and has been reworked as per Wolfgang's request.
Ed Okerson

In message Pine.LNX.4.44.0403032203130.14523-200000@dallas.texasconnect.net you wrote:
The attached patch fixes IDE problems for little endian systems. The previous patch was rejected (a couple of months ago) and has been reworked as per Wolfgang's request.
This patch is obsoleted by Leon Kukovec's patch of 02 Mar 2004.
I noted:
--- common/cmd_ide.c.new 2004-03-02 10:43:48.000000000 -0800 +++ common/cmd_ide.c 2004-03-03 19:55:37.625017368 -0800 ... @@ -242,7 +244,7 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, } } if (!ok) { - puts ("\nno IDE devices available\n"); + puts ("\nno IDE devices with partitions available\n"); rcode ++; } return rcode;
I don't see _any_ relevance to little endian systems here.
Please do not send patches where the description and the modification differ!!!
Please resubmit if you think this needs fixing.
Best regards,
Wolfgang Denk

On Sun, 14 Mar 2004, Wolfgang Denk wrote:
In message Pine.LNX.4.44.0403032203130.14523-200000@dallas.texasconnect.net you wrote:
The attached patch fixes IDE problems for little endian systems. The previous patch was rejected (a couple of months ago) and has been reworked as per Wolfgang's request.
This patch is obsoleted by Leon Kukovec's patch of 02 Mar 2004.
I'll check his out and see if it addresses all the issues I had.
I noted:
--- common/cmd_ide.c.new 2004-03-02 10:43:48.000000000 -0800 +++ common/cmd_ide.c 2004-03-03 19:55:37.625017368 -0800 ... @@ -242,7 +244,7 @@ int do_ide (cmd_tbl_t *cmdtp, int flag, } } if (!ok) {
puts ("\nno IDE devices available\n");
} return rcode;puts ("\nno IDE devices with partitions available\n"); rcode ++;
I don't see _any_ relevance to little endian systems here.
Please do not send patches where the description and the modification differ!!!
Sorry, that one slipped in as it was something I had changed so it ended up in the diff. I do think that it is needed as the original error message also appears in other places, and the new one is more descriptive of what the problem really is.
Ed Okerson
participants (2)
-
Ed Okerson
-
Wolfgang Denk