[U-Boot] Initial environment variables

When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific #define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?
Thanks for the help.
Ron

On Thursday 16 July 2009 14:57:10 Ron Madrid wrote:
When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific #define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?
not CONFIG_EXTRA_ENV_SETTINGS
look at common/env_common.c to see what defines are available to you -mike

Ron,
Ron Madrid wrote:
When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific #define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?
You can set CONFIGs for all of these things in your own private build and they'll work, but they're inappropriate for main-line U-boot. I hope the reasoning is obvious.
Thanks for the help.
Ron ________
regards, Ben
participants (3)
-
Ben Warren
-
Mike Frysinger
-
Ron Madrid