[PATCH] config: Enable USB Keyboard support on RPi4
Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
---
Note that rpi_arm64_defconfig already supports USB keyboard. This is to be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
configs/rpi_4_32b_defconfig | 1 + configs/rpi_4_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index dd7da1cf06..9c5ad7684e 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs/rpi_4_32b_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6eeec4592e..1a92cd637e 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525
On 05.05.2020 16:51, Nicolas Saenz Julienne wrote:
Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
Reviewed-by: Sylwester Nawrocki s.nawrocki@samsung.com
Note that rpi_arm64_defconfig already supports USB keyboard. This is to be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
Thanks for the patch, USB keyboard worked well for me on rpi4. I actually used that feature to verify my PCIe/xHCI patch series.
On Tue, May 5, 2020 at 10:51 PM Nicolas Saenz Julienne nsaenzjulienne@suse.de wrote:
Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
Note that rpi_arm64_defconfig already supports USB keyboard. This is to be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
configs/rpi_4_32b_defconfig | 1 + configs/rpi_4_defconfig | 1 + 2 files changed, 2 insertions(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On 05/05/2020 16:51, Nicolas Saenz Julienne wrote:
Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
Note that rpi_arm64_defconfig already supports USB keyboard. This is to be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
configs/rpi_4_32b_defconfig | 1 + configs/rpi_4_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index dd7da1cf06..9c5ad7684e 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs/rpi_4_32b_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525
It seems we are missing CONFIG_SYS_STDIO_DEREGISTER=y at least for me without this, U-Boot does not build.
Regards, Matthias
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6eeec4592e..1a92cd637e 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525
Hi Matthias,
On 08.05.2020 17:55, Matthias Brugger wrote:
It seems we are missing CONFIG_SYS_STDIO_DEREGISTER=y at least for me without this, U-Boot does not build.
Isn't it selected by USB_KEYBOARD? I also had related build issues which disappeared after running "make clean".
On 08/05/2020 18:41, Sylwester Nawrocki wrote:
Hi Matthias,
On 08.05.2020 17:55, Matthias Brugger wrote:
It seems we are missing CONFIG_SYS_STDIO_DEREGISTER=y at least for me without this, U-Boot does not build.
Isn't it selected by USB_KEYBOARD? I also had related build issues which disappeared after running "make clean".
Correct. Sorry for the noise.
Matthias
On 05/05/2020 16:51, Nicolas Saenz Julienne wrote:
Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
Applied to rpi-next now. I dropped the hunk for 32 bit for now, please resend once 32 bit support got accepted.
Regards, Matthias
Note that rpi_arm64_defconfig already supports USB keyboard. This is to be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
configs/rpi_4_32b_defconfig | 1 + configs/rpi_4_defconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index dd7da1cf06..9c5ad7684e 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs/rpi_4_32b_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6eeec4592e..1a92cd637e 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -42,6 +42,7 @@ CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_KEYBOARD=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525
participants (4)
-
Bin Meng -
Matthias Brugger -
Nicolas Saenz Julienne -
Sylwester Nawrocki