-----Original Message----- From: Ben Warren [mailto:biggerbadderben@gmail.com] Sent: Saturday, May 30, 2009 9:36 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH] Marvell MV88E1116 PHY Driver support

Hi Prafulla,

On Fri, May 29, 2009 at 11:34 PM, Prafulla Wadaskar prafulla@marvell.com wrote:

Hi Ben Thanks for accepting MV88E61xx driver code. Ping for mv88f1116 driver....... :-) This is dependency for sheevaplug board support.

I've already commented on this one. We don't currently have a framework for PHYs and I don't want to add PHY support ad-hoc. For now, PHY support needs to go in whatever ethernet driver uses it.

Hi Ben

Don't you think keeping phy support in Ethernet driver will harm to keep it's generic approach? through development and reviews we always try to keep any driver generic so that it can be used by others.

As of now apart from switch mv88e61xx, there is no phy support in driver/net/phy/. Being this first one- May I take this opportunity to help you to create a framework for PHYs?

Regards.. Prafulla . .

regards, Ben