regression with sunxi: psci: avoid error address-of-packed-member
After [1] on a Orange Pi Zero I hang on Starting kernel.
While this commit changed the order of clamp_set fixing it did not solve the problem for me. It appears that the problem is simply that a memcpy to sunxi_prcm_reg.cpu_pwroff does not have the same behaviour as writing a single bit.
Thanks, Nuno
[1] https://github.com/u-boot/u-boot/commit/9bd34a69a453d409792e08c00953ce886214...
On 1/10/20 4:30 PM, Nuno Gonçalves wrote:
After [1] on a Orange Pi Zero I hang on Starting kernel.
While this commit changed the order of clamp_set fixing it did not solve the problem for me.
Do you mean that both with and without the patch your system does not start?
Best regards
Heinrich
It appears that the problem is simply that a memcpy to sunxi_prcm_reg.cpu_pwroff does not have the same behaviour as writing a single bit.
Thanks, Nuno
[1] https://github.com/u-boot/u-boot/commit/9bd34a69a453d409792e08c00953ce886214...
On Fri, Jan 10, 2020 at 6:51 PM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 1/10/20 4:30 PM, Nuno Gonçalves wrote:
While this commit changed the order of clamp_set fixing it did not solve the problem for me.
Do you mean that both with and without the patch your system does not start?
Affirm. Even after restoring the clamp_set order it did not work for me.
Thanks
Hi,
I found that the commit was not reverted yet. Am I missing something? Is this code working in any sunxi H2+/H3?
Thanks, Nuno
On Fri, Jan 10, 2020 at 6:54 PM Nuno Gonçalves nunojpg@gmail.com wrote:
On Fri, Jan 10, 2020 at 6:51 PM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 1/10/20 4:30 PM, Nuno Gonçalves wrote:
While this commit changed the order of clamp_set fixing it did not solve the problem for me.
Do you mean that both with and without the patch your system does not start?
Affirm. Even after restoring the clamp_set order it did not work for me.
Thanks
On Thu, Mar 12, 2020 at 04:58:08PM +0100, Nuno Gonçalves wrote:
Hi,
I found that the commit was not reverted yet. Am I missing something? Is this code working in any sunxi H2+/H3?
Thanks, Nuno
On Fri, Jan 10, 2020 at 6:54 PM Nuno Gonçalves nunojpg@gmail.com wrote:
On Fri, Jan 10, 2020 at 6:51 PM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 1/10/20 4:30 PM, Nuno Gonçalves wrote:
While this commit changed the order of clamp_set fixing it did not solve the problem for me.
Do you mean that both with and without the patch your system does not start?
Affirm. Even after restoring the clamp_set order it did not work for me.
Jagan, do you want me to apply this revert directly? Thanks!
participants (3)
-
Heinrich Schuchardt -
Nuno Gonçalves -
Tom Rini