[PATCH 1/2] cmd: clk: cosmetic: correct code alignment in show_clks
Correct code alignment in show_clks() function.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
cmd/clk.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/cmd/clk.c b/cmd/clk.c index 439736d072..ba4540334a 100644 --- a/cmd/clk.c +++ b/cmd/clk.c @@ -25,24 +25,24 @@ static void show_clks(struct udevice *dev, int depth, int last_flag) if (device_get_uclass_id(dev) == UCLASS_CLK && clkp) { rate = clk_get_rate(clkp);
- printf(" %-12u %8d ", rate, clkp->enable_count); - - for (i = depth; i >= 0; i--) { - is_last = (last_flag >> i) & 1; - if (i) { - if (is_last) - printf(" "); - else - printf("| "); - } else { - if (is_last) - printf("`-- "); - else - printf("|-- "); + printf(" %-12u %8d ", rate, clkp->enable_count); + + for (i = depth; i >= 0; i--) { + is_last = (last_flag >> i) & 1; + if (i) { + if (is_last) + printf(" "); + else + printf("| "); + } else { + if (is_last) + printf("`-- "); + else + printf("|-- "); + } } - }
- printf("%s\n", dev->name); + printf("%s\n", dev->name); }
list_for_each_entry(child, &dev->child_head, sibling_node) {
Update depth only when clock uclass is found to have correct display of command "clk dump".
Without this patch, the displayed depth is the binding depth for all the uclass and that can be strange as only clock uclass nodes are displayed.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
cmd/clk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/clk.c b/cmd/clk.c index ba4540334a..e3c3d2f9bb 100644 --- a/cmd/clk.c +++ b/cmd/clk.c @@ -23,6 +23,7 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
clkp = dev_get_clk_ptr(dev); if (device_get_uclass_id(dev) == UCLASS_CLK && clkp) { + depth++; rate = clk_get_rate(clkp);
printf(" %-12u %8d ", rate, clkp->enable_count); @@ -47,7 +48,7 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
list_for_each_entry(child, &dev->child_head, sibling_node) { is_last = list_is_last(&child->sibling_node, &dev->child_head); - show_clks(child, depth + 1, (last_flag << 1) | is_last); + show_clks(child, depth, (last_flag << 1) | is_last); } }
On Thu, 30 Jul 2020 at 06:04, Patrick Delaunay patrick.delaunay@st.com wrote:
Update depth only when clock uclass is found to have correct display of command "clk dump".
Without this patch, the displayed depth is the binding depth for all the uclass and that can be strange as only clock uclass nodes are displayed.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
cmd/clk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Thu, 30 Jul 2020 at 06:04, Patrick Delaunay patrick.delaunay@st.com wrote:
Correct code alignment in show_clks() function.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
cmd/clk.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
participants (2)
-
Patrick Delaunay -
Simon Glass