Re: [U-Boot] [PATCH] net/designware: Add-on: Consecutive writes must have delay

8 Jun 2012


      Dear Dinh,
In message 71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com you wrote:
...
...
Sorry, but this commit message is misleading - I was expecting to see
something like udelay() in the code, but there wasn't any...
Combining the 2 individual writes into a single write will also work.
I'm just keeping in sync with commit # f6c4191f.
I understand this - but the commit message should match the code.
...
Again, just keeping the code in sync with the previous commit that address this issue. If you like, I can change it to setbits_le32().
I think it would be cleaner, but if the rest of the code looks like
that, I will not insist.
Best regards,
Wolfgang Denk
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"...one of the main causes of the fall of the Roman Empire was  that,
lacking  zero,  they had no way to indicate successful termination of
their C programs."                                     - Robert Firth

Wolfgang Denk

tags (0)

participants (1)