[PATCH] common: board_f: fix to display wrong memory information
When run meminfo command, it's displayed wrong memory information. Because it's using gd->ram_size what didn't configure ram size.
On 4G RPI4 target - Before U-Boot> meminfo DRAM: 948MiB - After U-Boot> meminfo DRAM: 3.9GiB
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com --- common/board_f.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_f.c b/common/board_f.c index 9f441c44f176..96c675ea28e4 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -228,6 +228,7 @@ static int show_dram_config(void) } debug("\nDRAM: ");
+ gd->ram_size = size; print_size(size, ""); board_add_ram_info(0); putc('\n');
On 12/29/20 6:24 PM, Jaehoon Chung wrote:
When run meminfo command, it's displayed wrong memory information. Because it's using gd->ram_size what didn't configure ram size.
what -> which?
On 4G RPI4 target
- Before U-Boot> meminfo DRAM: 948MiB
- After U-Boot> meminfo DRAM: 3.9GiB
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
common/board_f.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_f.c b/common/board_f.c index 9f441c44f176..96c675ea28e4 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -228,6 +228,7 @@ static int show_dram_config(void) } debug("\nDRAM: ");
- gd->ram_size = size;
Shouldn't this be set by dram_init?
--Sean
print_size(size, ""); board_add_ram_info(0); putc('\n');
On 12/30/20 8:48 AM, Sean Anderson wrote:
On 12/29/20 6:24 PM, Jaehoon Chung wrote:
When run meminfo command, it's displayed wrong memory information. Because it's using gd->ram_size what didn't configure ram size.
what -> which?
Will update
On 4G RPI4 target
- Before
U-Boot> meminfo DRAM: 948MiB
- After
U-Boot> meminfo DRAM: 3.9GiB
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
common/board_f.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_f.c b/common/board_f.c index 9f441c44f176..96c675ea28e4 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -228,6 +228,7 @@ static int show_dram_config(void) } debug("\nDRAM: "); + gd->ram_size = size;
Shouldn't this be set by dram_init?
Yes, it's set by dram_init(), I didn't think about only rpi's problem. I will check other target. (I have checked only RPI..) Thanks for pointing out.
Best Regards, Jaehoon Chung
--Sean
print_size(size, ""); board_add_ram_info(0); putc('\n');
Hi,
On 12/30/20 9:05 AM, Jaehoon Chung wrote:
On 12/30/20 8:48 AM, Sean Anderson wrote:
On 12/29/20 6:24 PM, Jaehoon Chung wrote:
When run meminfo command, it's displayed wrong memory information. Because it's using gd->ram_size what didn't configure ram size.
what -> which?
Will update
On 4G RPI4 target
- Before
U-Boot> meminfo DRAM: 948MiB
- After
U-Boot> meminfo DRAM: 3.9GiB
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
common/board_f.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_f.c b/common/board_f.c index 9f441c44f176..96c675ea28e4 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -228,6 +228,7 @@ static int show_dram_config(void) } debug("\nDRAM: "); + gd->ram_size = size;
Shouldn't this be set by dram_init?
Yes, it's set by dram_init(), I didn't think about only rpi's problem. I will check other target. (I have checked only RPI..) Thanks for pointing out.
Sorry for late checking. I have checked other boards with meminfo command.
In VIM3 4G
Model: Khadas VIM3 SoC: Amlogic Meson G12B (A311D) Revision 29:b (10:2) DRAM: 3.8 GiB
..[snip]..
meminfo
DRAM: 1.9 GiB
There is a bug to display information. I will resend patch v2.
Best Regards, Jaehoon Chung
Best Regards, Jaehoon Chung
--Sean
print_size(size, ""); board_add_ram_info(0); putc('\n');
participants (2)
-
Jaehoon Chung -
Sean Anderson